Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct highlight menu colour #2112

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: correct highlight menu colour #2112

merged 1 commit into from
Jun 6, 2023

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented May 9, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR corrects an issue in the 'highlight menu', where it was picking up the secondary colour for links where it should use a medium grey.

Note: this fix is also included in #2109 but it's more of a bear to test; a smaller PR will help get it into the next release!

How to test the changes in this Pull Request:

  1. Add a topic highlight menu to the site.
  2. Change your secondary colour to something not-grey.
  3. View on the front-end; note that the links in the menu are incorrectly picking up your secondary colour.
  4. Apply the PR and run npm run build.
  5. Confirm that the topic highlight menu is now correctly using grey for the links.
  6. Switch your site to Newspack Nelson; this theme is a little different because it places the topic highlight menu "inside" of the menu space, so we need to make sure the colours are still working right.
  7. Navigate to Customizer > Header > Appearance and turn off the Solid Background; confirm the menu uses grey text.
  8. Navigate to Customizer > Header > Appearance and turn on Solid background; navigate to Customizer > Colours, and turn off custom colours, so it's using the default Newspack blue. Confirm that the menu uses white text.
  9. Navigate to Customizer > Colours and change the header to a darker, then lighter colour. Confirm that the menu has adequate contrast against each (switching between black or white).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label May 9, 2023
@laurelfulford laurelfulford requested a review from a team as a code owner May 9, 2023 19:25
@leogermani leogermani self-requested a review June 1, 2023 21:53
leogermani
leogermani approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as described!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jun 1, 2023
@laurelfulford
Copy link
Contributor Author

Thanks @leogermani!

@laurelfulford laurelfulford merged commit 6a18039 into master Jun 6, 2023
@laurelfulford laurelfulford deleted the fix/highlight-menu-colour branch June 6, 2023 16:45
matticbot pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 1.74.0-alpha.1 [skip ci]
243ddbc 
# [1.74.0-alpha.1](v1.73.0...v1.74.0-alpha.1) (2023-06-08)

### Bug Fixes

* correct highlight menu colour ([#2112](#2112)) ([6a18039](6a18039))

### Features

* register header and footer colors to Multibranded plugin ([#2124](#2124)) ([7854f97](7854f97))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.74.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 19, 2023
@semantic-release-bot
chore(release): 1.74.0 [skip ci]
2218ac4 
# [1.74.0](v1.73.0...v1.74.0) (2023-06-19)

### Bug Fixes

* correct highlight menu colour ([#2112](#2112)) ([6a18039](6a18039))
* correct typo in the multi-branded site UI ([#2137](#2137)) ([c3106ff](c3106ff))
* move caption check to fix campaigns issue ([#2127](#2127)) ([90e9555](90e9555))

### Features

* register header and footer colors to Multibranded plugin ([#2124](#2124)) ([7854f97](7854f97))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @leogermani