Twitter Timeline: fix Undefined index notice

[jeherve]

tweet-limit was undefined in defaults

Read more about the issue here:
http://wordpress.org/support/topic/undefined-index-tweet-limit

[georgestephanis]

Displaying it as 0 in the form could be confusing to users, thinking that no tweets would display.

Would it be better to default it to null, maybe? That would still get cast to 0 in the output.

[jeherve]

On WordPress.com, we display a small message below the input field. Maybe we should do the same in Jetpack?

[wpmnger]

Why not just display 'no limit'?

[jeherve]

Displaying "No Limit" by default might be nice, but let's imagine the following scenario:

1. I create a Twitter Timeline widget
2. I set the number of tweets to show to 3.
3. A few days/weeks later, I come back and want to show an unlimited number of tweets

• How will I know what to enter into the box to display an unlimited number of tweets?
• If a message is there to explain that 0 = No limit, it's going to be easier to change than asking users to type in "No Limit", in my opinion.

[wpmnger]

I see your point.
For WP developers I guess -1 would be fitting :-)

I don't know how to explain this but I'll try:
In general I find the name of the field a little confusing. Setting a value to '# of tweets shown' will change the widget from being scrollable to being fixed and will override the height chosen in the previous input.
At first I thought it would just limit the amount of tweets pulled into the scrollable steam. What it does is makes the stream not scrollable and expands its height to display the fixed number of tweets with no load more option.

What would you say to a toggle option?

• no limit (when selected let's you choose a height)
• limit # of tweets shown (when selected let's you choose a number between 1 and 20)

[georgestephanis]

As per the Official Twitter Timeline documentation the tweet-limit (if provided) would need to be between 1 and 20, so we should also change the input type to number and add min and max attributes.

If not provided, I'd sooner see it display as blank, rather than a number that could be misleading. So maybe add a sanitize snippet like if ( 0 == (int) $tweet_limit ) $tweet_limit = null;

[Viper007Bond]

Not all browsers support number, do they? A dropdown with 1 to 20 seems like a better choice.

Also I agree with blank being better than 0. 0 is just confusing.

[georgestephanis]

If they don’t support number, it’ll just display as a normal text input.  Nothing lost, and PHP can normalize the input on save.

George Stephanis
Sent with Airmail

On December 18, 2013 at 2:41:43 PM, Alex Mills (notifications@github.com) wrote:

Not all browsers support number, do they? A dropdown with 1
to 20 seems like a better choice.

Also I agree with blank being better than 0. 0 is just confusing.

---

Reply to this email directly or view it on GitHub:
#6 (comment)

[georgestephanis]

Looks good.