First pass at action #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Dashboard restyling to align it with the Jetpack branding * Refactor a bunch of things to use and reuse the same wrappers for all views. Add notices. Add footer. Put fatal error into a warning notice. * Stylize all UI messages consistently * Refactor to render the main content first without outputting it, and save whether the link to the VaultPress online dashboard must be shown or not This data is luego used in the caller function that handles the general rendering * Introduce the Jetpack logo package and place it under the footer * Use the gray version of the Jetpack logo * Move notice styles to a new stylesheet so they have a consistent look throughout the wp admin. Add classes so the notices are moved by WP core below the heading * Add a prompt so user has to confirm that they want to reset VP options in database * Set correct alert level for notices * Fix issue where I reverted a condition to test and didn't put it back as it was. * Fix wrapper width on large screens. Make cards stack on small screens. * Link the Powered by Jetpack to the Jetpack dashboard if it exists or jetpack.com otherwise * Hide heading served remotely in certain UI messages * Fix offset layout when Jetpack is deactivated. This is because when JP is active there's a different class in the body than when it's inactive and VP stands on its own admin screen * Fix layout of top notice on mobile * Hide notices that are shown above the dashboard wrapper just like we do in Jetpack
jeherve
added a commit
that referenced
this pull request
Aug 12, 2021
* Readme: add PHP version requirement. * Standardize structure & move old changelogs to separate file * It makes things easier for translators, they don't need to focus on translating old strings. * It makes the current changelog stand out a bit more. * Update plugin version to Beta * Changelog: add #6 * Remove bug fix section We may not need it in this release * Add testing file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: