Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM: Resolves 3389 - remove axios dependencies #34315

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Nov 27, 2023

CRM: Resolves Automattic/zero-bs-crm#3389 - remove axios dependencies

Proposed changes:

In #34238 the axios dependency was updated. However, we really don't even need this dependency, as we can just use fetch.

This PR removes the axios dependency in favor of fetch, adding a small callAutomationsAPI wrapper function. I also fixed a few React errors due to items not having a key prop and table data not being wrapped in <thead> and <tbody>.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

No functionality should have changed between trunk and the fix/crm/3389-remove_axios_dependencies branch. Likewise, automations is behind a feature flag.

  1. Enable automations feature flag:
    add_filter( 'jetpack_crm_feature_flag_automations', '__return_true' );
    add_filter( 'jetpack_crm_feature_flag_api_v4', '__return_true' );
    
  2. Go to the automations dashboard: /wp-admin/admin.php?page=jpcrm-automations#/automations
  3. Ensure it is populated with any workflows you'd previously added, and that you can edit them. If you don't have any, there are two example workflows in CRM: Add Send_Email action + create a typical real automation scenario for a business #33424.

@tbradsha tbradsha requested a review from a team November 27, 2023 18:14
@tbradsha tbradsha added [Plugin] CRM Issues about the Jetpack CRM plugin [CRM] Automations Module labels Nov 27, 2023
@tbradsha tbradsha added this to the crm/6.3.1 milestone Nov 27, 2023
@tbradsha tbradsha self-assigned this Nov 27, 2023
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 27, 2023
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/crm/3389-remove_axios_dependencies branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/crm/3389-remove_axios_dependencies
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/crm/3389-remove_axios_dependencies
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@tbradsha tbradsha added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 27, 2023
coder-karen
coder-karen previously approved these changes Dec 4, 2023
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me .

@tbradsha tbradsha force-pushed the fix/crm/3389-remove_axios_dependencies branch from c1ab53b to 47b1e21 Compare December 4, 2023 17:42
@tbradsha tbradsha merged commit cd94ffd into trunk Dec 4, 2023
63 checks passed
@tbradsha tbradsha deleted the fix/crm/3389-remove_axios_dependencies branch December 4, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[CRM] Automations Module [Plugin] CRM Issues about the Jetpack CRM plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants