Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency axios to v1.6.2 #34238

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Update dependency axios to v1.6.2 #34238

merged 2 commits into from
Nov 21, 2023

Conversation

matticbot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
axios (source) devDependencies patch 1.6.0 -> 1.6.2
axios (source) dependencies patch 1.6.0 -> 1.6.2

Release Notes

axios/axios (axios)

v1.6.2

Compare Source

Features
  • withXSRFToken: added withXSRFToken option as a workaround to achieve the old withCredentials behavior; (#​6046) (cff9967)
PRs
  • feat(withXSRFToken): added withXSRFToken option as a workaround to achieve the old `withCredentials` behavior; ( #​6046 )

📢 This PR added 'withXSRFToken' option as a replacement for old withCredentials behaviour. 
You should now use withXSRFToken along with withCredential to get the old behavior.
This functionality is considered as a fix.
Contributors to this release

v1.6.1

Compare Source

Bug Fixes
  • formdata: fixed content-type header normalization for non-standard browser environments; (#​6056) (dd465ab)
  • platform: fixed emulated browser detection in node.js environment; (#​6055) (3dc8369)
Contributors to this release
PRs
  • feat(withXSRFToken): added withXSRFToken option as a workaround to achieve the old `withCredentials` behavior; ( #​6046 )

📢 This PR added 'withXSRFToken' option as a replacement for old withCredentials behaviour. 
You should now use withXSRFToken along with withCredential to get the old behavior.
This functionality is considered as a fix.

Configuration

📅 Schedule: Branch creation - "before 3am on the first day of the month" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Nov 21, 2023
@github-actions github-actions bot added [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Tests] Includes Tests E2E Tests labels Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the renovate/axios-1.x branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack renovate/axios-1.x
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin renovate/axios-1.x
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@anomiex anomiex enabled auto-merge (squash) November 21, 2023 20:56
@anomiex anomiex merged commit 27219ec into trunk Nov 21, 2023
63 checks passed
@anomiex anomiex deleted the renovate/axios-1.x branch November 21, 2023 21:01
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 21, 2023
@simison
Copy link
Member

simison commented Nov 22, 2023

@anomiex have you considered just dropping Axios? See example; ping @noahtallen

@anomiex
Copy link
Contributor

anomiex commented Nov 22, 2023

Looks like the three direct uses are crm (pinging @Automattic/avengers), super-cache (pinging @Automattic/heart-of-gold), and the E2E tests (which no one really owns anymore, but look easy to fix).

Even if we drop it, some of our dependencies (@slack/web-api, localtunnel) still use it.

@cleacos
Copy link
Contributor

cleacos commented Nov 23, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Tests] Includes Tests [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants