General: remove WP 6.1 backwards compatibility checks #32772

jeherve · 2023-08-30T18:10:05Z

Proposed changes:

This removes backwards compatibility checks for WordPress 6.1, since our plugins will now require WP 6.2 (see #32762).

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

WordPress 6.3 compatibility #31638

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Is CI happy?
Check the different apps impacted by this change.

See #31638 This mostly removes checks that were added in #28710

github-actions · 2023-08-30T18:25:31Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Beta plugin:

Next scheduled release: October 3, 2023.
Scheduled code freeze: September 25, 2023.

Jetpack plugin:

Next scheduled release: September 19, 2023.
Scheduled code freeze: September 11, 2023.

Boost plugin:

Next scheduled release: October 3, 2023.
Scheduled code freeze: September 25, 2023.

Social plugin:

Next scheduled release: October 3, 2023.
Scheduled code freeze: September 25, 2023.

Starter Plugin plugin:

Next scheduled release: October 3, 2023.
Scheduled code freeze: September 25, 2023.

Protect plugin:

Next scheduled release: October 3, 2023.
Scheduled code freeze: September 25, 2023.

Migration plugin:

Next scheduled release: October 3, 2023.
Scheduled code freeze: September 25, 2023.

github-actions · 2023-08-30T18:25:45Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/wp-61-backcompat-janitorial branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/wp-61-backcompat-janitorial

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

anomiex · 2023-08-30T19:42:29Z

projects/packages/backup/src/js/index.js

 	const container = document.getElementById( 'jetpack-backup-root' );

 	if ( null === container ) {
 		return;
 	}

-	// @todo: Remove fallback when we drop support for WP 6.1
-	const component = (
+	render(


Looks like you got all these backwards. It's the if case (using createRoot().render()) that needs to be kept, not the else case.

See https://github.com/Automattic/jetpack/actions/runs/6029259977/job/16358366809?pr=32772#step:9:695 for the problem this causes.

see #20590

See #32772 (comment)

jeherve · 2023-08-31T10:12:56Z

projects/plugins/jetpack/_inc/lib/admin-pages/class-jetpack-redux-state-helper.php

-						function_exists( 'wp_theme_has_theme_json' ) ? wp_theme_has_theme_json() : WP_Theme_JSON_Resolver::theme_has_support()
-					) && function_exists( 'wp_register_webfont_provider' ) && function_exists( 'wp_register_webfonts' ),
+					'webfonts'        => wp_theme_has_theme_json()
+						&& ( function_exists( 'wp_register_webfont_provider' ) || function_exists( 'wp_register_webfonts' ) ),


wp_register_webfonts and wp_register_webfont_provider are not yet in Core.

jeherve · 2023-08-31T10:17:44Z

I took care of the comments you left above, thanks for the feedback!

Did a search for function_exists being called on wp_-prefixed functions. Not entirely sure these can all be removed, since often enough WordPress doesn't load files in some entry points (and sometimes wpcom lacks functions loaded even if WP itself would have them).

I like that idea, that's a clever way to find things that can maybe be removed. I took a look and removed those that seemed safe to remove. 👍

…pat-janitorial

anomiex

Let's go for it.

…pat-janitorial

jeherve · 2023-09-05T06:04:38Z

This will need another review after bumping package versions. Thank you!

General: remove WP 6.1 backwards compatibility checks

84b9188

See #31638 This mostly removes checks that were added in #28710

jeherve added General [Status] In Progress [Type] Janitorial [Pri] Normal labels Aug 30, 2023

jeherve requested a review from anomiex August 30, 2023 18:10

jeherve self-assigned this Aug 30, 2023

jeherve mentioned this pull request Aug 30, 2023

WordPress 6.3 compatibility #31638

Closed

7 tasks

jeherve added this to the jetpack/12.6 milestone Aug 30, 2023

Bump versions

4a5ec5b

jeherve added 2 commits August 30, 2023 20:36

Remove error-free file

42b9c90

Update usages of the \WpOrg\Requests classes

a97e707

anomiex reviewed Aug 30, 2023

View reviewed changes

jeherve added 5 commits August 31, 2023 11:12

Remove temporary backwards-compatibility fix

62b45ac

see #20590

Move away from experimental prop

a526cef

Update comment since WP Fonts API is not in Core yet

cfb8b5d

changelog

3ce12e1

Remove backwards-compatiblity function checks

6b610a9

See #32772 (comment)

github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Google Fonts Provider This package no longer exists in the monorepo. [Package] WAF E2E Tests labels Aug 31, 2023

jeherve commented Aug 31, 2023

View reviewed changes

Remove more backwards-compatibility function checks

5c4c850

github-actions bot added [Feature] Shortcodes / Embeds [Feature] Widget Visibility [Package] Status [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta labels Aug 31, 2023

Update tests

eba4afd

jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Aug 31, 2023

Merge remote-tracking branch 'origin/trunk' into update/wp-61-backcom…

09cd94d

…pat-janitorial

anomiex previously approved these changes Sep 4, 2023

View reviewed changes

Merge remote-tracking branch 'origin/trunk' into update/wp-61-backcom…

4a11575

…pat-janitorial

jeherve enabled auto-merge (squash) September 5, 2023 05:57

Bump versions

b0d7402

jeherve dismissed anomiex’s stale review via b0d7402 September 5, 2023 06:00

anomiex approved these changes Sep 5, 2023

View reviewed changes

jeherve merged commit 27c040a into trunk Sep 5, 2023

jeherve deleted the update/wp-61-backcompat-janitorial branch September 5, 2023 13:23

github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General: remove WP 6.1 backwards compatibility checks #32772

General: remove WP 6.1 backwards compatibility checks #32772

jeherve commented Aug 30, 2023

github-actions bot commented Aug 30, 2023 •

edited

Loading

github-actions bot commented Aug 30, 2023 •

edited

Loading

anomiex Aug 30, 2023

jeherve Aug 31, 2023

jeherve commented Aug 31, 2023 •

edited

Loading

anomiex left a comment

jeherve commented Sep 5, 2023

General: remove WP 6.1 backwards compatibility checks #32772

General: remove WP 6.1 backwards compatibility checks #32772

Conversation

jeherve commented Aug 30, 2023

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Aug 30, 2023 • edited Loading

github-actions bot commented Aug 30, 2023 • edited Loading

anomiex Aug 30, 2023

Choose a reason for hiding this comment

jeherve Aug 31, 2023

Choose a reason for hiding this comment

jeherve commented Aug 31, 2023 • edited Loading

anomiex left a comment

Choose a reason for hiding this comment

jeherve commented Sep 5, 2023

github-actions bot commented Aug 30, 2023 •

edited

Loading

github-actions bot commented Aug 30, 2023 •

edited

Loading

jeherve commented Aug 31, 2023 •

edited

Loading