Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: update WordPress requirements to WP 6.2 #32762

Merged
merged 1 commit into from
Aug 30, 2023
Merged

General: update WordPress requirements to WP 6.2 #32762

merged 1 commit into from
Aug 30, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Aug 30, 2023

See #31638

Proposed changes:

Now that WordPress 6.3 and folks have had some time to update to the most recent version of WordPress, let's start requiring WP 6.2 for everyone wanting to use our different plugins.

This also reverts #32366.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Is CI happy?

@jeherve jeherve added General [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Aug 30, 2023
@jeherve jeherve added this to the jetpack/12.6 milestone Aug 30, 2023
@jeherve jeherve requested a review from zinigor August 30, 2023 13:36
@jeherve jeherve self-assigned this Aug 30, 2023
@jeherve jeherve mentioned this pull request Aug 30, 2023
Closed
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/wp-requirements-62 branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/wp-requirements-62

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Aug 30, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

  • Next scheduled release: September 19, 2023.
  • Scheduled code freeze: September 11, 2023.

Backup plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Search plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Social plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Starter Plugin plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Protect plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Videopress plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Super Cache plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Migration plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

Inspect plugin:

  • Next scheduled release: September 5, 2023.
  • Scheduled code freeze: August 28, 2023.

@jeherve jeherve enabled auto-merge (squash) August 30, 2023 13:57
@anomiex
Copy link
Contributor

anomiex commented Aug 30, 2023

More stuff to clean up:

Also these comments seem likely to need a version bump, it looks like it didn't make it into 6.2 (or 6.3).

@jeherve
Copy link
Member Author

jeherve commented Aug 30, 2023

More stuff to clean up

I was planning on doing this in a different PR once this will be merged, that would focus on remove the now unnecessary backwards compatibility checks.

anomiex
anomiex approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning on doing this in a different PR once this will be merged, that would focus on remove the now unnecessary backwards compatibility checks.

Works for me!

@jeherve jeherve merged commit d7f7861 into trunk Aug 30, 2023
@jeherve jeherve deleted the update/wp-requirements-62 branch August 30, 2023 18:02
@jeherve jeherve mentioned this pull request Aug 30, 2023
Merged
3 tasks
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 30, 2023
TimBroddin pushed a commit that referenced this pull request Sep 5, 2023
@jeherve @TimBroddin
[not verified] General: update WordPress requirements to WP 6.2 (#32762)
231d1b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

@zinigor zinigor Awaiting requested review from zinigor

Assignees

@jeherve jeherve

Labels
Actions GitHub actions used to automate some of the work around releases and repository management General [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Janitorial
Projects
None yet
Milestone
jetpack/12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jeherve @anomiex