Social Logos: update icon font #28849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7148 - It adds some new logos, that one can see directly by loading `yoursite.com/wp-content/plugins/jetpack/_inc/social-logos/social-logos.html` - It removes the handling of an `eot` file when declaring the icon font. This is no longer necessary with modern browsers. See discussion below and commit 84c2ece for more details. This is needed for #28694.
jeherve
added
[Feature] Sharing
7 tasks
github-actions
bot
added
the
[Plugin] Jetpack
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run to get started. More details: p9dueE-5Nn-p2 |
jeherve
added
[Status] Needs Review
kraftbj
approved these changes
Feb 8, 2023
github-actions
bot
removed
the
[Status] Needs Review
jeherve
added
the
[Status] Needs Testing
jeherve
added a commit
that referenced
this pull request
Feb 9, 2023
samiff
removed
the
[Status] Needs Testing
This was referenced Mar 13, 2023
jeherve
added a commit
that referenced
this pull request
Mar 13, 2023
Follow-up to #28849 In #28849, we moved away from using a base64-encoded font and an eot file for multiple reasons: - #6076 - #7148 - #28694 (comment) Instead, we switched to loading 3 files from local paths: - woff2, supported by all modern browsers: https://caniuse.com/woff2 - woff and ttf, around for compatibility with old browsers: https://css-tricks.com/snippets/css/using-font-face-in-css/ Given how widespread woff2 support looks like today, we may be able to use just that. We will, however, need to revert to a base64-encoded font to avoid CORS issues when the files are served from a CDN, like Photon CDN: Access to font at 'https://c0.wp.com/p/jetpack/11.9/_inc/social-logos/social-logos.woff2' from origin 'https://yoursite.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Both approaches seem to be problematic: - base64-encoded fonts are broken for some people. - fonts loaded via a path have CORS issues for everyone using a CDN. => This seems like the biggest problem for us right now, given that Jetpack includes such a CDN. This commit is consequently not a perfect solution. Switching to SVGs, as discussed in #28861, seems to be the path forward.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7148
Proposed changes:
yoursite.com/wp-content/plugins/jetpack/_inc/social-logos/social-logos.htmleotfile when declaring the icon font. This is no longer necessary with modern browsers.See discussion in #28694 and commit 84c2ece for more details.
This is needed for #28694.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
yoursite.com/wp-content/plugins/jetpack/_inc/social-logos/social-logos.html