Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Logos CSS Not Optimized #13201

Closed
ScottTravisHartley opened this issue Aug 8, 2019 · 3 comments
Closed

Social Logos CSS Not Optimized #13201

ScottTravisHartley opened this issue Aug 8, 2019 · 3 comments
Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Performance [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@ScottTravisHartley
Copy link

ScottTravisHartley commented Aug 8, 2019

When evaluating the performance impact of various plugins I decided to look at JetPack that was rather strange albeit not a major issue it is a present one.

Files:
/jetpack/_inc/social-logos/social-logos.min.css
&
/jetpack/_inc/social-logos/social-logos.css

Are currently unoptimized.

  1. The .woff file shouldn't be inlined with a data attribute it should just be included as a URL like the rest but more importantly some oddness.
  2. Due to the inclusion of two @font-face rules the .eot file is loaded unnecessarily regardless of browser type (such as on chrome).
  3. The .woff2 file simply isn't present in the file but it is included in the plugin files which would further reduce weight.
@jeherve
Copy link
Member

jeherve commented Sep 19, 2019

Noting that the first patch to fix that problem (in #13363) could not be merged as it causes issues in some use cases, detailed in the comments of that PR.

@stale
Copy link

stale bot commented Mar 17, 2020

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@jeherve
Copy link
Member

jeherve commented Mar 13, 2023

This should be fixed as of #28849

@jeherve jeherve closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Performance [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants