Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: modal should open clicked image, and not 1st img in gallery #11022

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Carousel: modal should open clicked image, and not 1st img in gallery #11022

merged 1 commit into from
Dec 21, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 20, 2018

Fixes #10747

Changes proposed in this Pull Request:

  • This PR allows Carousel to detect the clicked image in any gallery block, not just old galleries.

Testing instructions:

  • Start with a site where the Carousel module is active.
  • Go to Posts > Add New
  • Create a post with a new Gallery block, and publish.
  • Go to the post and click on any image in the gallery.
  • That image should open in the Carousel modal.
  • Test the same thing, but with a regular gallery inserted into a Classic block.

Proposed changelog entry for your changes:

  • Carousel: ensure that Carousel works well with the Gallery block in the new block editor.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 20, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 20, 2018
@jeherve jeherve self-assigned this Dec 20, 2018
@jeherve jeherve requested a review from a team December 20, 2018 17:02
@matticbot
Copy link
Contributor

D22599-code. (newly created revision)

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 9a92fa0

brbrr
brbrr approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 👍

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. labels Dec 21, 2018
@zinigor zinigor merged commit 7cb3a5d into master Dec 21, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 21, 2018
@zinigor zinigor deleted the fix/carousel-block-gallery branch December 21, 2018 13:15
jeherve added a commit that referenced this pull request Dec 21, 2018
@jeherve
Changelog: add #11022
49133ff
@simison simison mentioned this pull request Dec 28, 2018
Closed
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #11022
f9bf20b
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
@jeherve jeherve mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @brbrr @zinigor