Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: add new card for managing plugins. #10924

Merged
merged 5 commits into from
Dec 11, 2018
Merged

Settings: add new card for managing plugins. #10924

merged 5 commits into from
Dec 11, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 10, 2018

Fixes #10694

Changes proposed in this Pull Request:

This PR adds a new card for managing plugins.

When connected
screenshot 2018-12-10 at 22 36 23

When in dev mode

screenshot 2018-12-10 at 22 49 55

Testing instructions:

  • Go to Jetpack > Settings while your site is in dev mode, with Manage active, or with Manage off.
  • Make sure the new card in the Security tab looks good.

Proposed changelog entry for your changes:

  • Settings: add new card for plugins management.

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. Admin Page React-powered dashboard under the Jetpack menu labels Dec 10, 2018
@jeherve jeherve self-assigned this Dec 10, 2018
@jeherve jeherve requested review from joanrho and a team December 10, 2018 22:01
@jetpackbot
Copy link
Collaborator

jetpackbot commented Dec 10, 2018 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 24bdeca

@oskosk
Copy link
Contributor

oskosk commented Dec 11, 2018

This one also needs a rebase to help 0c1819c9965b4de8699fe7c1842470f048606ef7

oskosk
oskosk previously approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after rebasing!

Note that manage being on or off (mentioned in the testing instructions) does not make a difference in the aspect of this new card.

@jeherve jeherve force-pushed the add/plugins-manage-card branch from 0c1819c to 7e8b79a Compare December 11, 2018 16:36
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. labels Dec 11, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 11, 2018
@jeherve jeherve added the [Status] Needs Design Review Design has been added. Needs a review! label Dec 11, 2018
@jeherve
Copy link
Member Author

jeherve commented Dec 11, 2018

I rebased. Ready for a design review before merge, maybe?

@keoshi
Copy link
Contributor

keoshi commented Dec 11, 2018

@jeherve From now on, it would be awesome if you could add the entire @Automattic/jetpack-design group on the PR review. I've asked Derek to add this yesterday, so everyone can consistently ping us and get a faster review hopefully. Will review right away — thanks!

@jeherve jeherve requested a review from a team December 11, 2018 16:45
oskosk
oskosk previously requested changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I want to propose something

@jeherve jeherve dismissed oskosk’s stale review December 11, 2018 16:58

Feedback addressed.

keoshi
keoshi reviewed Dec 11, 2018
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in my testing! One thing I'd like to address before we merge if possible — the corresponding card on the dashboard looks different:

image

  • Dashboard card: replace chevron/arrow with external icon.
  • Dashboard card: open link in new tab/window.
  • Settings card: change label to “Manage your plugins”.

@jeherve
Settings card: change label to "Manage your plugins".
cdd9713
@jeherve
Dashboard card: update to make it look more similar to settings
24bdeca 
- replace chevron/arrow with external icon.
- open link in new tab/window.
- run prettier
@jeherve
Copy link
Member Author

jeherve commented Dec 11, 2018

I've updated both cards according to your feedback, thank you!

screenshot 2018-12-11 at 18 21 46

oskosk
oskosk approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 11, 2018
@keoshi keoshi removed the [Status] Needs Design Review Design has been added. Needs a review! label Dec 11, 2018
@jeherve jeherve merged commit 16e2e0b into master Dec 11, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 11, 2018
@jeherve jeherve deleted the add/plugins-manage-card branch December 11, 2018 18:23
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
changelog: add #10924
fdc1aea
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
changelog: add #10924
51908c6
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keoshi keoshi keoshi left review comments

@oskosk oskosk oskosk approved these changes

@joanrho joanrho Awaiting requested review from joanrho

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @oskosk @keoshi @matticbot