Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing buttons: Specific sharing configuration results in misleading page editor display #25329

Closed
coder-karen opened this issue Jul 29, 2022 · 4 comments · Fixed by #25346
Closed
Assignees
Labels
Build Maintenance Build Group maintenance tasks [Feature] Sharing Post sharing, sharing buttons [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@coder-karen
Copy link
Contributor

coder-karen commented Jul 29, 2022

Impacted plugin

Jetpack

Steps to Reproduce

This issue is specific to a particular configuration of sharing settings. While this can be replicated in both beta and previous versions of Jetpack and there are existing, similar issues, this issue is more pronounced as a result of this PR - #24896 - because sharing buttons now shouldn't display at all on pages with the Blog Posts block.

  1. On a Jetpack connected site, make sure Sharing and / or Like buttons are enabled via Jetpack > Settings > Sharing.
  2. From Settings > Sharing, make sure 'Front Page, Archive Pages, and Search Results' is checked, as well as Posts.
  3. Add and activate the WordPress.com Editing Toolkit plugin.
  4. Add a new page, and add a Blog Posts block.
  5. In the page editor, you should see some unformatted sharing / like button output.
  6. On the page preview / frontend, you should not see the sharing buttons / likes (if testing with 11.2-beta).
  7. From Settings > Sharing, disable 'Front page, Archive Pages, and Search results' and the page editor should go back to it's normal view (no sharing / like button output).

It looks like this might be the case on all themes - all that I've tested so far display this behavior: Twenty Twenty One, Astra, BlockBase, Twenty Twenty Two, Twenty Twenty, Twenty Nineteen.

This was reported internally here: p8oabR-Uj-p2#comment-6512

A clear and concise description of what you expected to happen.

No sharing / like button output should show in the page editor at all.

What actually happened

Sharing / like button output is showing in the page editor.

Browser

Google Chrome/Chromium

Other information

The output in the editor looks like this:
Screenshot 2022-07-29 at 12 19 06

There are two other related issues at the moment:

Platform (Simple, Atomic, or both?)

Self-hosted

Reproducibility

Consistent

Severity

Most (> 50%)

Available workarounds?

No response

Workaround details

No response

@coder-karen coder-karen added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Needs triage Ticket needs to be triaged labels Jul 29, 2022
@jeherve jeherve added [Pri] Normal Triaged and removed Needs triage Ticket needs to be triaged labels Jul 29, 2022
@jeherve
Copy link
Member

jeherve commented Jul 29, 2022

cc @wojtekn and @danielbachhuber, who worked on #24896

@wojtekn
Copy link
Contributor

wojtekn commented Jul 29, 2022

@coder-karen I've checked the provided steps on the local Jetpack site, and I reproduced the issue. Then I reverted #25329, and I still reproduce the issue in the editor.

It seems an editor issue was in place, and in related PR we fixed the frontend part but missed the issue in the backend. Is it what you observed too?

I'm happy to help with checking this though.

@wojtekn wojtekn self-assigned this Jul 29, 2022
@coder-karen
Copy link
Contributor Author

Yes the editor issue existed before the PR. So the PR hasn't introduced the issue, but it stands out more because the frontend (within the Blog Posts block) doesn't show sharing buttons now.

@wojtekn
Copy link
Contributor

wojtekn commented Jul 29, 2022

@coder-karen thanks for validating that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Maintenance Build Group maintenance tasks [Feature] Sharing Post sharing, sharing buttons [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants