Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for trailing / to be removed from JiraServerUrl #373

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Added check for trailing / to be removed from JiraServerUrl #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8911265
Added check for trailing `/` to be removed from `JiraServerUrl`
lipkau Aug 20, 2019
acf739e
Fixed tests
lipkau Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion JiraPS/Public/Get-JiraConfigServer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function Get-JiraConfigServer {
Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] ParameterSetName: $($PsCmdlet.ParameterSetName)"
Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] PSBoundParameters: $($PSBoundParameters | Out-String)"

return $script:JiraServerUrl
return ($script:JiraServerUrl -replace "\/$", "")
}

end {
Expand Down
2 changes: 1 addition & 1 deletion Tests/JiraPS.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Describe "General project validation" -Tag Unit {

Import-Module $env:BHManifestToTest -Force

Get-JiraConfigServer | Should -Be "https://example.com/"
Get-JiraConfigServer | Should -Be "https://example.com"
}

# It "module is imported with default prefix" {
Expand Down