Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for trailing / to be removed from JiraServerUrl #373

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Added check for trailing / to be removed from JiraServerUrl #373

merged 2 commits into from
Aug 20, 2019

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Aug 20, 2019 •
edited
Loading

Description

Added check for trailing / to be removed from JiraServerUrl

Motivation and Context

closes #372

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau requested review from a team as code owners August 20, 2019 10:37
@lipkau lipkau self-assigned this Aug 20, 2019
brianbunke
brianbunke approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@brianbunke brianbunke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lipkau lipkau merged commit d6ecd39 into AtlassianPS:master Aug 20, 2019
@glennsarti
Copy link

🎉 Thanks @brianbunke @lipkau

@lipkau lipkau deleted the fix/#372-RemoveTrailingSlashFromJiraServerUrl branch September 16, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbunke brianbunke brianbunke approved these changes

Assignees

@lipkau lipkau

Labels
Area:Module Issue:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jira 2.12.0 can no longer query my Jira Server
3 participants
@lipkau @glennsarti @brianbunke