Enhance/paging #291
Merged
Enhance/paging #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # JiraPS/Public/Invoke-JiraMethod.ps1
extracted several blocks into private function to make the code more readable
* Added messages for deprecated parameter * Added missing parameter descriptions (including implicit parameters) * Changed parameter types to UInts * Fixed filtering of Get-Filter results * Added tests for new paging parameters
PSv6 will try to validate the headers - and "Content-Type" will fail
ghost
added
the
brianbunke
previously approved these changes
Jun 14, 2018
Moved name of ConvertTo-Session function to be a local variable of the module
brianbunke
approved these changes
Jun 26, 2018
Merged
lipkau
added a commit
that referenced
this pull request
Jun 28, 2018
### IMPROVEMENTS - Added support for paginated response from API server by means of `-Paging` (#291, [@lipkau[]]) - Added full set of functions to manage Filter Permissions (#289, [@lipkau[]]) - Added `-Id` parameter to `Remove-JiraFilter` (#288, [@lipkau[]]) - Changed logic of `Get-JiraUser` to return multiple results for a search (#272, [@lipkau[]]) - Added posts for homepage to the module's repository (#268, [@lipkau[]]) - Improved handling of _Credentials_ (#271, [@lipkau[]]) - Added missing interactions with _Filters_ (#266, [@lipkau[]]) - Added `Remove-JiraIssue` (#265, [@hmmwhatsthisdo[]]) - Improved Build script (to deploy changes to the homepage) (#259, [@lipkau[]]) ### BUG FIXES - Reverted `Add-JiraIssueAttachament` as JiraPS v2.7 broke it (#287, [@lipkau[]]) - Fixed resolving of Remote Link (#286, [@lipkau[]]) - Improved error handling for ErrorDetails and non-JSON/HTML responses (#277, [@hmmwhatsthisdo[]]) - Fully support Powershell v3 (#273, [@lipkau[]]) - Fixed parameter used in documentation but not in code (#263, [@lipkau[]])
lipkau
added a commit
that referenced
this pull request
Jun 29, 2018
### IMPROVEMENTS - Added support for paginated response from API server by means of `-Paging` (#291, [@lipkau[]]) - Added full set of functions to manage Filter Permissions (#289, [@lipkau[]]) - Added `-Id` parameter to `Remove-JiraFilter` (#288, [@lipkau[]]) - Changed logic of `Get-JiraUser` to return multiple results for a search (#272, [@lipkau[]]) - Added posts for homepage to the module's repository (#268, [@lipkau[]]) - Improved handling of _Credentials_ (#271, [@lipkau[]]) - Added missing interactions with _Filters_ (#266, [@lipkau[]]) - Added `Remove-JiraIssue` (#265, [@hmmwhatsthisdo[]]) - Improved Build script (to deploy changes to the homepage) (#259, [@lipkau[]]) ### BUG FIXES - Reverted `Add-JiraIssueAttachament` as JiraPS v2.7 broke it (#287, [@lipkau[]]) - Fixed resolving of Remote Link (#286, [@lipkau[]]) - Improved error handling for ErrorDetails and non-JSON/HTML responses (#277, [@hmmwhatsthisdo[]]) - Fully support Powershell v3 (#273, [@lipkau[]]) - Fixed parameter used in documentation but not in code (#263, [@lipkau[]])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of a generic handling of paginated results from Atlassian's API
Motivation and Context
closes #114
Types of changes
Checklist: