Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted logic to upload attachments #287

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Jun 14, 2018

Added the logic for uploading a file back into Add-JiraIssueAttachament.
This closes #248
This is continued by #284

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

Added the logic for uploading a file back into Add-JiraIssueAttachament.
This closes AtlassianPS#248
This is continued by AtlassianPS#284
@lipkau lipkau added this to the v2.8 milestone Jun 14, 2018
@lipkau lipkau self-assigned this Jun 14, 2018
@lipkau lipkau requested review from a team as code owners June 14, 2018 10:43
@ghost ghost added the Status:In Review label Jun 14, 2018
@ghost ghost added the Status:In Review label Jun 14, 2018
@lipkau lipkau removed the Blocked label Jun 14, 2018
@lipkau lipkau merged commit 6cc9209 into AtlassianPS:develop Jun 14, 2018
@lipkau lipkau deleted the revert/UploadOfAttachments branch June 14, 2018 17:25
@ghost ghost removed the Status:In Review label Jun 14, 2018
@lipkau lipkau mentioned this pull request Jun 28, 2018
lipkau added a commit that referenced this pull request Jun 28, 2018
### IMPROVEMENTS

- Added support for paginated response from API server by means of `-Paging` (#291, [@lipkau[]])
- Added full set of functions to manage Filter Permissions (#289, [@lipkau[]])
- Added `-Id` parameter to `Remove-JiraFilter` (#288, [@lipkau[]])
- Changed logic of `Get-JiraUser` to return multiple results for a search (#272, [@lipkau[]])
- Added posts for homepage to the module's repository (#268, [@lipkau[]])
- Improved handling of _Credentials_ (#271, [@lipkau[]])
- Added missing interactions with _Filters_ (#266, [@lipkau[]])
- Added `Remove-JiraIssue` (#265, [@hmmwhatsthisdo[]])
- Improved Build script (to deploy changes to the homepage) (#259, [@lipkau[]])

### BUG FIXES

- Reverted `Add-JiraIssueAttachament` as JiraPS v2.7 broke it (#287, [@lipkau[]])
- Fixed resolving of Remote Link (#286, [@lipkau[]])
- Improved error handling for ErrorDetails and non-JSON/HTML responses (#277, [@hmmwhatsthisdo[]])
- Fully support Powershell v3 (#273, [@lipkau[]])
- Fixed parameter used in documentation but not in code (#263, [@lipkau[]])
lipkau added a commit that referenced this pull request Jun 29, 2018
### IMPROVEMENTS

- Added support for paginated response from API server by means of `-Paging` (#291, [@lipkau[]])
- Added full set of functions to manage Filter Permissions (#289, [@lipkau[]])
- Added `-Id` parameter to `Remove-JiraFilter` (#288, [@lipkau[]])
- Changed logic of `Get-JiraUser` to return multiple results for a search (#272, [@lipkau[]])
- Added posts for homepage to the module's repository (#268, [@lipkau[]])
- Improved handling of _Credentials_ (#271, [@lipkau[]])
- Added missing interactions with _Filters_ (#266, [@lipkau[]])
- Added `Remove-JiraIssue` (#265, [@hmmwhatsthisdo[]])
- Improved Build script (to deploy changes to the homepage) (#259, [@lipkau[]])

### BUG FIXES

- Reverted `Add-JiraIssueAttachament` as JiraPS v2.7 broke it (#287, [@lipkau[]])
- Fixed resolving of Remote Link (#286, [@lipkau[]])
- Improved error handling for ErrorDetails and non-JSON/HTML responses (#277, [@hmmwhatsthisdo[]])
- Fully support Powershell v3 (#273, [@lipkau[]])
- Fixed parameter used in documentation but not in code (#263, [@lipkau[]])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants