Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Branch #46

Merged
merged 9 commits into from
Feb 17, 2021
Merged

Conversation

Astul-Betizagasti
Copy link
Owner

No description provided.

RobertGlobant20 and others added 9 commits February 8, 2021 10:21
* Revert "First version with migration from packages.config to package reference (#11186)"

This reverts commit c7a5e49.

* Revert "Revert "First version with migration from packages.config to package reference (#11186)""

This reverts commit 5906c99.

* Issues Type Predicter GitHub Action

I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue.

Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"
Changes the publish package dialog to use checkboxes rather than a
context menu to select which dlls are node libraries. Also adds an
instructive text on top to further guide users.
* Revert "First version with migration from packages.config to package reference (#11186)"

This reverts commit c7a5e49.

* Revert "Revert "First version with migration from packages.config to package reference (#11186)""

This reverts commit 5906c99.

* Issues Type Predicter GitHub Action

I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue.

Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"

* Fix for the GitHub token

When testing the issue predicter workflow the issues labeled as Wishlist were not moved to the DynamoWishlist repo due that the "Move Issue by labels" workflow failed. There was a problem with the PAT used to label the issue, I was using the wrong one (no triggers actions).
…ns null (#11479)

* wip use prod code when name returns null

* add new mock setup
add friend assembly for moq
add test
fix broken tests
add fallback for interface

* remove as stmt

Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>
Make the link point to latest "not beta" release rather than old version
add image

Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>
update tests
remove test debug config

Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>
This happened when the amount of suggestions for an input surpassed a
certain number of suggestions. The cause was the following condition.

It turns out that popups, like autocomplete, close when the left mouse
button up event happens. The problem is that autocomplete itself is
launched by pressing the left mouse button. This would normally mean
that the popup would hide as soon as the button was released, but this
was actually prevented through a time condition, which ignored the
event if it was 'soon enough'.

Unfortunately, in cases where there were a lot of suggestions, the left
mouse button up event can come after the expected timespan. This
resulted in the workaround failing to prevent the popup from hiding
immediately.

The newly implemented solution replaces the previous time-based
workaround with a more robust solution, which is to ignore the next
event after the call to show the popup is made.
@Astul-Betizagasti Astul-Betizagasti merged commit 81233d5 into Astul-Betizagasti:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants