Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove debug modes for python #11499

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Feb 11, 2021

Purpose

This PR removes the debug modes for Ironpython obsolete and python engine selection ui. So these features are now enabled by default.

Tests are updated to no longer set the debug mode and the test config is removed.

IronPython warnings will now be raised when opening dyn/dyfs unless the preference for suppressing them is selected or the session per graph "do not show again" checkbox is enabled.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

FYI @Amoursol

update tests
remove test debug config
@QilongTang
Copy link
Contributor

@mjkkirschner It looks fine. I think we discussed before the context menu of engine switch being a temp solution. With now we have count down of removing IronPython OOTB, do you think we can slowly remove the engine switches from context menu?

Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjkkirschner
Copy link
Member Author

sure @QilongTang @Amoursol - though it does seem pretty useful to change versions without opening the editor... defer to you guys of course - let me know if you want me to remove it in this PR?

@QilongTang
Copy link
Contributor

QilongTang commented Feb 11, 2021

sure @QilongTang @Amoursol - though it does seem pretty useful to change versions without opening the editor... defer to you guys of course - let me know if you want me to remove it in this PR?

hmm after thinking about it, I feel let's not touch the scope of this PR. I will log a Jira and put into backlog. It might be worth to check the actual behavior with IronPython removed, what does the switch do. I will add that in that task.

@mjkkirschner mjkkirschner merged commit 862ce3b into DynamoDS:master Feb 11, 2021
@mjkkirschner mjkkirschner deleted the turnpy2warnon branch February 11, 2021 20:17
@Amoursol
Copy link
Contributor

@mjkkirschner @QilongTang I concur with the above commentary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants