Update master #23
Merged
Update master #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update LibG NuGet packages * Re-baseline JSON to current output
* Image.WriteToFile dynamo annotation **NODE: Image.WriteToFile** -CHANGES: Output Name: success Output result= (was not working, added a message: File has been succesfully written * Image.Dimension Node Annotations **NODE: Image.Dimensions** -CHANGES: Output Descriptions: Width: width of image in pixels Height: height of image in pixels * FileSystem.WriteText Annotation Update **NODE: FileSystem.WriteText** -CHANGES: Output Name: success Output Description: Success message if file was written correctly Output result= , added a message: File has been succesfully written * WriteToFile and Write To text change description Word Success added * FileSystem.ReadText Annotation Update **NODE: FileSystem.ReadText** -CHANGES: Output : str to string InputDescription: file: File object to read text from * Update path from directory **NODE: Directory From Path** -CHANGES: Output Description : Path to the directory. (string) * Revert "Update path from directory" This reverts commit a913da4. * Remove unused reference * Directory from Path input description updated new description: type: string (Path to the directory) * Revert changing assemblyfileversion * Add icons for nodes Data.ParseJSON Data.StringifyJSON, Geometry.ToSolidDef, Geometry.FromSolidDef Added missing icons * Directory From Path Output updated * Image.WriteToFile and FileSystem.WriteText Output updated Output reverted to void
* Nodes Range and Sequence Update **NODE: Sequence** -CHANGES: Input description: Amount of numbers or letters in the sequence Output seq to sequence **NODE: Range** -CHANGES: Output seq to sequence * TimeSpan Annotation Update **NODE: TimeSpan.Components** -CHANGES: Output description: days: Amount of days on TimeSpan hours: Amount of hours on TimeSpan minutes: Amount of minutes on TimeSpan seconds: Amount of seconds on TimeSpan milliseconds: Amount of milliseconds on TimeSpan * Object.IsNull Annotation Update **NODE: Object.IsNull** -CHANGES: Description: Determines if the given object is null. Input: obj to object Output : bool to boolean * Object.Identity Annotation Update **NODE: Object.Identity** -CHANGES: Input: obj to object Output : var[]..[] to object * DateTime.TimeOfDay Annotation Update **NODE: DateTime.TimeOfDay** -CHANGES: Output: var to TimeSpan Output Description: TimeSpan since midnight * DateTime.Date Annotation Update **NODE: DateTime.Date** -CHANGES: Output: var to date Output Description: date from DateTime new search options: Date, DataTime.Date * Update Map input f(x) to function * Revert "Nodes Range and Sequence Update" This reverts commit 77b8156. * Range and Sequence Updated Range: Output: seq to sequence Description: Amount of numbers or letters in the sequence Sequence: Output: seq to sequence * DateTime.Date search updated Node name erased from search, Node name is not required for search * TimeSpan.Components outputs descriptions updated outputs descriptions updated to include datatype * Object.IsNull output name update boolean to -> bool * Sequence and range nodes output name and output description updated Sequence and Range: output name: list output list description : type: var[]..[] (New list) * List.Map output name updated output name mapped -> list output description: type: var[]..[] (mapped list) * List.Deconstruct output descriptions updated output first description: type: var[]..[] (first item in the list) output rest description: type: var[]..[] (rest of the list) * Description type of output is placed after description of output
* Math.DivRem Math.Cosh Math.Cos Math.Atan2 Math.Atan Math.Asin Math.Acos **NODE: Math.DivRem** -CHANGES: Output: The remainder of the division (int) **NODE: Math.Cosh** -CHANGES: Output: Hyperbolic cosine of the angle (double) **NODE: Math.Cos** -CHANGES: Output: Cosine of the angle (double) **NODE: Math.Atan2** -CHANGES: Output: The angle whose tangent is numerator/denominator (double) **NODE: Math.Atan** -CHANGES: Output: The angle whose tangent is the input ratio (double) **NODE: Math.Asin** -CHANGES: Output: The angle whose sine is the input ratio (double) **NODE: Math.Acos** -CHANGES: Output: The angle whose cosine is the input ratio. (double) * Cos Node Improve Description * List.SortByKey Annotations Update **NODE: List.SortByKey** -CHANGES: Output: sortedList,sortedKeys -Input Description: keys: list of keys, keys have to be sortable (ex: numbers,strings) Output Description: sortedList: List sorted using keys sortedKeys: Keys sorted * List.SortByFunction Update Input: sortFunction Description: function used to sort list Output: sortedList Description: list sorted by function * Output Math.Cos and Math.Cosh Updated cos to double cosh to double * Update outputs for atan and atan2 atan: Angle to double atan2: Angle to double * Updates for asin and acos Asin: angle to double Acos: angle to double * Remove object type in description Remove object type in description because its already shown in output name * Math.DivRem output name updated integer to int * List.SortByKey output description updated sortedLists: type: var[]..[] sortedKeys: type: var[]..[] * List.SortByKey update input description input keys description: keys have to be sortable (e.g. numbers,strings) * List.SortByFunction and List.Sublists output description updated output description updated to include datatype * Math.Sinh Solve conflicts with master branch
* Update String.cs **NODE: String.Replace** -CHANGES: Change input and output from str to string **NODE: String.Remove** -CHANGES: Change input and output from str to string -The count has no default value, so will eliminate description part where it specifies what happends if you dont have a value **NODE: String.Insert** -CHANGES: Change input and output from str to string **NODE: String.AllIndicesOf** -CHANGES: Change input and output from str to string Description: Finds a list of zero-based indexes of occurrence of a sub-string inside a string. InputDescriptions: string: A string to search in. searchFor: Substring to search for. ignoreCase: Whether or not comparison takes case into account. Output Description: indexList: List of indices or ints where substring is found Search: all indices of,find substring,where,search **NODE: String.Join** -CHANGES: Change output from str to string **NODE: String.Concat** -CHANGES: Change output from str to string * AllIndicesOf Description Improved * Descriptions for ScopeIf improved * WhileLoop Annotation Update * ScopeIf Annotation Update * ScopeIf and If descriptions Block returned if test is false to Returned if test is false Block returned if test is true to Returned if test is true Boolean to determine what code block is returned to Boolean test * IndexOf correct extra comment lines /// /// <search>all indices of,find substring,where,search</search> to /// <search>all indices of,find substring,where,search</search> * ScopeIf Node Description updated New description: Looks up a localized string similar to Returns the result of either the True or False input depending on what boolean value is toggled in the test input. * LoopWhile output description updated New output description: type: var[]..[] (result from loop) * String.AllIndicesOf update output description List of indices (integers) where substring is found to type: int[] (list of indices where substring is found) * LoopWhile String.AllIndicesOf Output description updated Change description so that output description appears before object type.
* Watch Image Annotation Update **NODE: Watch Image** -CHANGES: Description: Input Description: Image for visualization * Color.Red Annotation Update **NODE: Color Red** -CHANGES: Description: Output Description: Red value for RGB color model, int between 0 and 255 inclusive. -UNABLE TO DO: Add color description Red is a property of color, so dont know how to add a description to the class * Color Red Annotation Update Change Output red to int * Color output Updated int to integer * Update Color.Red output name Change from integer to int to use DesignScript abbreviations * Image Preview: Input and output description updated Image -> Image for visualization
* List.Scan Annotation Update **NODE: List.Scan** -CHANGES: Output: scanned to list Inputs: list1 to list0 Input Description: list1 to List #0 * List.Reduce Annotation Update **NODE: List.Reduce** -CHANGES: Output: reduced to list Inputs: list1 to list0 Input Description: list1 to List #0 * List.Permutations Annotation Update **NODE: List.Permutations** -CHANGES: Output: perm to permutations CHECK: It is working in Automatic lacing * File From Path Annotation Updated **NODE: File From Path** -CHANGES: Description: Creates a file object from a path. A file object loads the selected file in memory for use downstream. Input description: Path to the file as string, * Node List.MaxumimItemByKey Output and Output Description Update Output: maxItem Output Description maximum item in list using keyProjector * Update List.MaximumItemByKey maxItem to maximumItem * Update File From Path Description Creates a file object from a path. A file object loads the selected file in memory for use downstream. to Creates a file object from a path. * List.MaximumItemByKey update output description Change the output description to show type * List.Permutations update output description Show datatype in output description * List.Scan, List.Reduce, List.Create update output description Update output description to show datatype. * List.MaximumItemByKey input name and output description updated input name: keyProjector -> keyFunction new output description: type: var[]..[] (maximum item in list using keyFunction) * List.Reduce, List.Scan input name updated reductor -> reduceFunction * List.MaximumItemByKey List.Scan, List.Reduce List.Permutations List.Create update output description Reverse order to show first description and then output type
* Web Request Annotations Update **NODE: Web Request** -CHANGES: Output result to string. Input Description: The url for the web request as a string., Output Description: Content of a webpage as a string. -NOT APPLICABLE: Name has spaces, does not have DS Syntax * Color.Saturation Annotation Update **NODE: Color.Saturation** -CHANGES: Output saturation to double. Output Description: Saturation value as double between 0 and 1 inclusive. * Thre **NODE: Thread.Pause** CHANGES: -Rename x in input and output to object. * Not Annotation Update **NODE: Not** CHANGES: Description: Reverses the result, returns false if the result is true Input Description: boolean to reverse UNABLE TO DO: Input: x to boolean Output: var[]..[] to boolean Output Description: reversed boolean * And + Or Annotation Update **NODE: Or** CHANGES: Input: bool0 to boolean0 Output empty to boolean Description: boolean to reverse Input Description operand to Boolean #0... **NODE: And** CHANGES: Input: bool0 to boolean0 Output empty to boolean Description: boolean to reverse Input Description operand to Boolean #0... * Not output and output description added Not output:boolean Output description reversed boolean * List.MinimumItemByKey Annotation Update 20) NODE: List.MinimumItemByKey Output: minItem Output Description: minimum item in list using keyProjector * WebRequest description changed Content of a webpage as a string. to Content of a web request as a string. * MinimumItemByKey update Output Output changed from minItem to minimumItem * List.MinimumItemByKey update output description Update output to reflect datatype: type: var[]..[] (minimum item in list using keyProjector) * Not update description Not Node description updated: Negates the input, e.g. returns false when the input is true. * Not, And,Or Nodes output + input name updated Changed from boolean to bool to use DesignScript base type abbreviations * Not node output description updated Inlcude type in output description * List.MinimumItemByKey update input name, and output description input name: keyProjector -> keyFunction new output description: type: var[]..[] (minimum item in list using keyFunction) * And & Or input update Change boolean to bool * List.MinimumItemByKey Output description updated type: var[]..[] (minimum item in list using keyFunction) to Minimum item in list using keyFunction (type: var[]..[])
* String from Object Annotations Update **NODE: String from Object** -CHANGES: Rename str to string, obj to object, Output description: String representation of the object. -NOT APPLICABLE: Name has spaces, does not have DS Syntax -FUTURE EDITS: Retain Existing -> Pending explanation from Sol * String from Array Annotations Update **NODE: String from Array** -CHANGES: Rename str to string, arr to array -NOT APPLICABLE: Name has spaces, does not have DS Syntax -FUTURE EDITS: Retain Existing -> Pending explanation from Sol * Function.Apply Annotations Update **NODE: Function Apply** -CHANGES: Rename func to function, arg1 to argument1 func(args) to result, Description: Returns the result of a function with supplied arguments. Ex: arguments of a point and vector are applied to a translate function returning a translated point. -NOT APPLICABLE: Name has spaces, does not have DS Syntax, items is not zero indexed, doesnt pass object-type * Function Compose Annotation Update **NODE: Function Compose** -CHANGES: Rename func0 to function0, fun to function Description: Returns a single function from multiple functions. Ex: the modulus and divide functions are composed into a single function to apply to a list. -NOT APPLICABLE: Name has spaces, does not have DS Syntax * List.LaceShortest List.LaceLongest List.Combine Annotation Update **NODES: List.LaceShortest List.LaceLongest List.Combine** -CHANGES: Rename comb to combinator, list1 to list0, combined to list Input Description: function to use as combinator * List.GroupByFunction Annotation Update **NODE: List.GroupByFunction** -CHANGES: Rename func to groupFunction, var[]..[] to list Description: Returns a new list grouped by a function. Description Inputs: groupFunction = function for grouping list groupedList = Grouped list * Using appropiate tooltip for Object to String description Tooltip FormulaPortDataResultToolTip was being used for String from Object output description * Function Apply index to 0 All indexes should start at 0 * List.GroupByFunction search update Eliminate groupByfunction search option as it is name of node and is not needed for search. * List.GroupByFunction Update output description List.GroupByFunction output description updated to reflect type: type: var[]..[] (list of arbitrary rank/levels) * List.LaceShortest, List.LaceLongest, List.Combine, List.CartesionProduct update input name combinator -> combineFunction * List.GroupByFunction update output description >type: var[]..[] (list of arbitrary rank/levels) to List of arbitrary rank/levels (type: var[]..[])
* Add icon for Solid.ByRuledLoft * Also add icon files externally to folder * Fix typo
…geometry (#11163) * sort helix elements for every selection changed event * refactor * image comparison test
…caling (#11166) * add CS display test with non-unity geometry scaling * add comment
…is selected (#11158) * Disable migration button for cpython3 engine * Update ScriptEditorWindow.xaml
* Focus extension when activated Modifies the mechanism used to add/display extensions to make sure the extension bar is actually visible and that the right tab is actually displayed. * Add unit test
* update config file to load LibG for ASM 227 for CI tests * update ASM test
* add geometry test for ASM fix in ASM 226 * mark test as Failure temporarily * remove failure category
* trial commit * update * place suggested node wrt node height and width * execute graph auto layout command after connecting input node * node auto layout for node autocomplete * revert unnecessary change * revert unnecessary change * cleanup * cleanup * rename parameter * rename variables * add code comments, null check * revert unnecessary change * more code comments * refactor into delegate command on nodesearchelementviewmodel * cleanup * remove unused usings Co-authored-by: tanga <aaron.tang@autodesk.com>
…Python editor window (#11182) * Python editor uiux fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.