Node consistency 81 90 #11141
Merged
Node consistency 81 90 #11141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master update
Master Branch Updated from DynamoDS/master
Fork Update 2020-09-07
**NODE: Sequence** -CHANGES: Input description: Amount of numbers or letters in the sequence Output seq to sequence **NODE: Range** -CHANGES: Output seq to sequence
**NODE: TimeSpan.Components** -CHANGES: Output description: days: Amount of days on TimeSpan hours: Amount of hours on TimeSpan minutes: Amount of minutes on TimeSpan seconds: Amount of seconds on TimeSpan milliseconds: Amount of milliseconds on TimeSpan
**NODE: Object.IsNull** -CHANGES: Description: Determines if the given object is null. Input: obj to object Output : bool to boolean
**NODE: Object.Identity** -CHANGES: Input: obj to object Output : var[]..[] to object
**NODE: DateTime.TimeOfDay** -CHANGES: Output: var to TimeSpan Output Description: TimeSpan since midnight
**NODE: DateTime.Date** -CHANGES: Output: var to date Output Description: date from DateTime new search options: Date, DataTime.Date
f(x) to function
This reverts commit 77b8156.
Range: Output: seq to sequence Description: Amount of numbers or letters in the sequence Sequence: Output: seq to sequence
Node name erased from search, Node name is not required for search
outputs descriptions updated to include datatype
boolean to -> bool
Sequence and Range: output name: list output list description : type: var[]..[] (New list)
output name mapped -> list output description: type: var[]..[] (mapped list)
output first description: type: var[]..[] (first item in the list) output rest description: type: var[]..[] (rest of the list)
Update changes from DynamoDS master branch 2020-09-23 09-52
|
@martinstacey Are the outputs descriptions in this format: |
Amoursol
approved these changes
Sep 30, 2020
aparajit-pratap
requested changes
Oct 1, 2020
There was a problem hiding this comment.
@martinstacey please address review comments before we can merge this PR. Thanks.
aparajit-pratap
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners.
81) NODE: List.Deconstruct
-CHANGES:
Output description:
first: type: var[]..[] (first item in the list)
rest: type: var[]..[] (rest of the list)
82) NODE: List.Map
-CHANGES:
Input: fx -> function
Output: mapped -> list
Output description list: type: var[]..[] (mapped list)
83) NODE: List.Cycle
-CHANGES:
Output description list: type: var[]..[] (list of repeated lists)
84) NODE: Sequence
-CHANGES:
Input description: Amount of numbers or letters in the sequence
Output seq to list
Output description list: type: var[]..[] (New list)
85) NODE: Range
-CHANGES:
Output seq to list
Output description list: type: var[]..[] (New list)
86) NODE: TimeSpan.Components
-CHANGES:
Output description:
days: type: int (amount of days)
hours: type: int (amount of hours)
minutes: type: int (amount of minutes)
seconds: type: int (amount of seconds)
milliseconds: type: int (amount of milliseconds)
87) NODE: Object.IsNull
-CHANGES:
Description: Determines if the given object is null.
88) NODE: Object.Identity
-CHANGES:
Input: obj to object
Output : var[]..[] to object
Output object description: Same object
89) NODE: DateTime.TimeOfDay
-CHANGES:
Output: var to TimeSpan
Output Description: TimeSpan since midnight
90) NODE: DateTime.Date
-CHANGES:
Output: var to date
Output Description: date from DateTime
Reviewers
@SHKnudsen
@Amoursol
@QilongTang
@aparajit-pratap
FYIs
-No FYI