Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm tracing test #1259

Merged
merged 4 commits into from
Jun 12, 2024
Merged

evm tracing test #1259

merged 4 commits into from
Jun 12, 2024

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Jun 10, 2024

Add EVM Tracing tests for runtime api
Add RPC tracing tests PR will be merged before this PR
Enable manual-seal together with evm-tracing

@ermalkaleci ermalkaleci added tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. ci This PR/Issue is related to the topic "CI" labels Jun 10, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/unified-accounts/src 100% 0%
primitives/src 61% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/collator-selection/src 92% 0%
pallets/unified-accounts/src 86% 0%
primitives/src/xcm 64% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/xcm/src 73% 0%
pallets/inflation/src 83% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/xvm/src 75% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-v3/src 92% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/sr25519/src 64% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
pallets/price-aggregator/src 72% 0%
pallets/ethereum-checked/src 79% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/xvm/src 54% 0%
pallets/oracle-benchmarks/src 0% 0%
pallets/static-price-provider/src 52% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
precompiles/assets-erc20/src 81% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/xc-asset-config/src 64% 0%
Summary 78% (3600 / 4635) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be great to add some info about manual seal in a README.
Apart from that LGTM

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Let's get this merge, so we can test out uplift PR

@ashutoshvarma ashutoshvarma mentioned this pull request Jun 12, 2024
@ermalkaleci ermalkaleci merged commit 6842af3 into master Jun 12, 2024
10 of 11 checks passed
@ermalkaleci ermalkaleci deleted the feat/evm-tracing-test branch June 12, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI" tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants