Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift to v1.5 #1256

Merged
merged 26 commits into from
Jul 12, 2024
Merged

Uplift to v1.5 #1256

merged 26 commits into from
Jul 12, 2024

Conversation

PierreOssun
Copy link
Member

@PierreOssun PierreOssun commented Jun 7, 2024

Uplift to v1.5

XCM: Use Message Queue as DMP and XCMP dispatch queue
Use Message Queue as DMP and XCMP dispatch queue #1246
Add Message Queue pallet & migration to remove DMP pallet+ Some changes to XCMP Queue pallet config

Contracts: Add XCM traits to interface with contracts
#2086
#1248
Removes contracts-primitives dep and replace it with uapi + Not activate XCM by setting to ()

Refactor ChainSpec
chain-spec: getting ready for native-runtime-free world #1256

Identity pallet changes
Identity pallet improvements #2048

StateBackend changes
sp-api: Move macro related re-exports to __private #2446
Move deps from sp_api to sc_client_api

Grandpa notification settings
Rework the event system of sc-network #1370

Also added:
pallet-xcm: enhance reserve_transfer_assets to support remote reserves #1672
pallet-xcm: add new flexible transfer_assets() call/extrinsic #2388

Astar owned repo updated:
Polkadot SDK
frontier
ORML

TODO:

  • fix CI
  • benchmark

@PierreOssun PierreOssun marked this pull request as draft June 7, 2024 12:19
@PierreOssun PierreOssun changed the title update Cargo deps to v1.5 and uplift Astar runtime Uplift to v1.5 Jun 7, 2024
@PierreOssun PierreOssun added runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels Jun 10, 2024
@PierreOssun PierreOssun added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya labels Jun 10, 2024
@PierreOssun PierreOssun marked this pull request as ready for review June 11, 2024 15:13
@ashutoshvarma
Copy link
Member

@PierreOssun once #1259 is merged, please merge master into your PR so we can have tests Ermal made?

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall
initial review, will take a more closer look tomorrow

runtime/astar/src/lib.rs Outdated Show resolved Hide resolved
runtime/astar/src/weights/pallet_xcm.rs Outdated Show resolved Hide resolved
runtime/astar/src/xcm_config.rs Show resolved Hide resolved
runtime/shibuya/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this migration is missing?
paritytech/polkadot-sdk#2142

@Dinonard
Copy link
Member

@ashutoshvarma just to confirm - you will integrate this part?
paritytech/polkadot-sdk#4578

@ashutoshvarma
Copy link
Member

ashutoshvarma commented Jun 12, 2024

@ashutoshvarma just to confirm - you will integrate this part? paritytech/polkadot-sdk#4578

@Dinonard Yes I'll

@PierreOssun
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_xcm

Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9501114705.
Please wait for a while.
Branch: uplift-sdk-v1.5
SHA: 3ba2283

Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9501114705.

@PierreOssun
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_xcm

Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9514536999.
Please wait for a while.
Branch: uplift-sdk-v1.5
SHA: a459e1b

Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9514536999.

@PierreOssun
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_xcm

Copy link

github-actions bot commented Jul 1, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9745988914.
Please wait for a while.
Branch: uplift-sdk-v1.5
SHA: a459e1b

Copy link

github-actions bot commented Jul 1, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9745988914.

@PierreOssun PierreOssun self-assigned this Jul 2, 2024
Copy link

github-actions bot commented Jul 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/src/test 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/xvm/src 54% 0%
pallets/oracle-benchmarks/src 0% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/xvm/src 75% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
chain-extensions/xvm/src 0% 0%
pallets/ethereum-checked/src 79% 0%
pallets/price-aggregator/src 72% 0%
primitives/src/xcm 64% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/unified-accounts/src 86% 0%
pallets/collator-selection/src 92% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/dispatch-lockdrop/src 86% 0%
primitives/src 62% 0%
pallets/static-price-provider/src 52% 0%
precompiles/sr25519/src 64% 0%
pallets/dapp-staking-v3/src 90% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/xcm/src 73% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/inflation/src 83% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
pallets/collective-proxy/src 86% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/xc-asset-config/src 64% 0%
Summary 77% (3704 / 4796) 0% (0 / 0)

Minimum allowed line rate is 50%

@ermalkaleci
Copy link
Contributor

#1290 Contains missing changes

@ermalkaleci ermalkaleci merged commit 7596fdc into master Jul 12, 2024
9 of 11 checks passed
@ermalkaleci ermalkaleci deleted the uplift-sdk-v1.5 branch July 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar client This PR/Issue is related to the topic “client”. runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants