feat(sqlx-storage): add base for sqlx storage #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwiss
added a commit
that referenced
this pull request
Nov 10, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Nov 10, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [x] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [x] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Nov 10, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
…#180) ## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> --------- Co-authored-by: Rémi Roycourt <remiroycourt@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
## Description
This pull request introduces significant updates to the `Orderbook`
contract, focusing on the implementation of listing order fulfillment
and the enhancement of testing scenarios.
#### Key Additions:
1. **Fulfilling Listing Order Functionality:**
- A new function, `fulfill_order`, has been added to handle the process
of fulfilling orders. This function takes in `execution_info` and
`signer` as parameters and follows these steps:
- Verifies the signer.
- Validates the existence of the order and its status.
- Checks if the order is open and not fulfilled by the same offerer.
- Distinguishes the order type and proceeds with the fulfillment process
for listing orders.
2. **Private Function for Listing Order Fulfillment:**
- The `_fulfill_listing_order` private function has been implemented to
specifically handle listing orders. It checks the order's expiration
date and updates the order status to 'Fulfilled' upon successful
execution.
3. **Enhanced Test Coverage:**
- New test scenarios have been added to validate the functionality:
- `test_create_listing_order_and_fulfill_non_existing_order`: Ensures
the system correctly handles attempts to fulfill non-existing orders.
- `test_create_listing_order_and_fulfill`: Tests the successful creation
and fulfillment of a listing order.
- `test_create_listing_order_and_fulfill_with_same_fulfiller`: Validates
that an order cannot be fulfilled by the same entity that created it.
These updates aim to streamline the order fulfillment process,
particularly for listing orders, while ensuring robustness through
comprehensive testing.
<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?
For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->
## What type of PR is this? (check all applicable)
- [x] 🍕 Feature (`feat:`)
- [ ] 🐛 Bug Fix (`fix:`)
- [ ] 📝 Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] 🧑💻 Code Refactor (`refactor:`)
- [ ] 🔥 Performance Improvements (`perf:`)
- [ ] ✅ Test (`test:`)
- [ ] 🤖 Build (`build:`)
- [ ] 🔁 CI (`ci:`)
- [ ] 📦 Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`)
## Related Tickets & Documents
<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
## Added tests?
- [x] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
## Added to documentation?
- [ ] 📜 README.md
- [ ] 📓 Documentation
- [x] 🙅 no documentation needed
## [optional] Are there any post-deployment tasks we need to perform?
<!-- Describe any additional tasks, if any, and provide steps. -->
## [optional] What gif best describes this PR or how it makes you feel?
<!-- Share a fun gif related to your PR! -->
### PR Title and Description Guidelines:
- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).
## Closing Issues
<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.
- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.
You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`
More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Nov 27, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Dec 8, 2023
## Description # New JS SDK Library for ArkChain Orderbook Interaction This pull request introduces a new SDK library specifically designed for interacting with the ArkChain orderbook. This library is a comprehensive toolset enabling users to effectively engage with ArkChain's functionalities. The following outlines the key features and components included in this initial release: ## Features - **Account Creation (Burner Wallet):** Facilitates the creation of new accounts, functioning as burner wallets for transactions. - **Listing Creation:** Provides the ability to create listings on the ArkChain orderbook. - **Offer Creation:** Enables the creation of offers within the orderbook environment. - **Order Cancellation:** Offers the functionality to cancel existing orders. - **Fulfilling Listings:** Introduces the capability to fulfill active listings in the orderbook. - **Fulfilling Offers:** Allows users to fulfill existing offers within the orderbook. ## Example Scripts - A set of example scripts are included to demonstrate practical applications of the SDK functions, such as creating accounts, listings, offers, and more. ## Testing - Comprehensive tests using Chai and Mocha have been added to validate the interaction with the ArkChain. These tests cover all the core features of the SDK, ensuring reliability and performance. This SDK represents a foundational step in streamlining and simplifying interactions with the ArkChain orderbook, providing developers with the tools necessary for efficient and effective blockchain engagements. ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> --------- Co-authored-by: Rémi Roycourt <remiroycourt@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…/ store burner account in local storage (#216) ## Description - Add react package (provider + store burner account in local storage logic) - Add demo app <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents Fixes #204 <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Dec 19, 2023
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Jan 1, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> --------- Co-authored-by: YohanTz <yohantancrez@gmail.com>
kwiss
added a commit
that referenced
this pull request
Jan 2, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [x] 🤖 Build (`build:`) - [x] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Jan 8, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Jan 8, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
remiroyc
pushed a commit
that referenced
this pull request
Jan 18, 2024
## Description <!-- Add some data events --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents Fixes #244 ## Added tests? - [ ] 👍 yes - [x] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
remiroyc
pushed a commit
that referenced
this pull request
Jan 22, 2024
## Description just remove a useless dependency ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [x] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Feb 7, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Feb 8, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Feb 15, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Feb 16, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Feb 22, 2024
## Description add a way to whitelist brokers & test if they are authorized to create, fulfill an order. <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Feb 26, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Description In the Solis sequencer, we've implemented a preliminary check of asset ownership and balance before pooling. This crucial step ensures that only assets genuinely owned by the user and with a sufficient balance are eligible for processing by the sequencer, thereby enhancing the security and integrity of transactions within Solis. <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Mar 8, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Mar 12, 2024
## Description Fix Core SDK tests ## What type of PR is this? (check all applicable) - [ ] ✅ Test (`test:`) ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> --------- Co-authored-by: kwiss <mr.dumont.christophe@gmail.com>
kwiss
pushed a commit
that referenced
this pull request
Mar 13, 2024
) ## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Jun 10, 2024
## Description - Fix fulfill of collection offer was never executed. - Now `token_id` is mandatory for collection offer fulfill info. <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Jun 13, 2024
…ion (#391) ## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> - For auction order, fulfiller and offerer could be the same. - Renamed some tests - For auction order, fulfill allowance is check for related order offerer. ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [x] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Jun 17, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Jun 17, 2024
## Description 1. add a way to save address in a json file 2. retrieve json file addresses if state is empty (when katana is restarted) ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Jul 6, 2024
## Description - Add support for ERC2981 royalty in starknet contract - Fix brokers fees computation - Update SDK to match new contract ABI for setting fees - Add ERC2981 component implementation <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Jul 17, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Jul 17, 2024
## Description The following public methods have been removed from `orderbook` contract: - whitelist_broker - unwhitelist_broker - create_order - cancel_order - fulfill_order `set_broker_fees` have been updated to use `caller` instead of `broker_address` argument. Fees denominator are limited to 10000 to prevent overflow in the executor contract. <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [x] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> --------- Co-authored-by: christophe <christophe@screenshot.co> Co-authored-by: kwiss <mr.dumont.christophe@gmail.com>
kwiss
added a commit
that referenced
this pull request
Jul 29, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Description
1. Update `orderbook::OrderExecuted` event with the following data:
```cairo
#[derive(Drop, starknet::Event)]
struct OrderExecuted {
#[key]
order_hash: felt252,
#[key]
order_status: OrderStatus,
version: u8,
transaction_hash: felt252,
from: ContractAddress,
to: ContractAddress,
}
```
2. Update diri to handle `OrderExecuted` version 0 and version 1
<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?
For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->
## What type of PR is this? (check all applicable)
- [x] 🍕 Feature (`feat:`)
- [ ] 🐛 Bug Fix (`fix:`)
- [ ] 📝 Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] 🧑💻 Code Refactor (`refactor:`)
- [ ] 🔥 Performance Improvements (`perf:`)
- [ ] ✅ Test (`test:`)
- [ ] 🤖 Build (`build:`)
- [ ] 🔁 CI (`ci:`)
- [ ] 📦 Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`)
## Related Tickets & Documents
<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
## Added tests?
- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
## Added to documentation?
- [ ] 📜 README.md
- [ ] 📓 Documentation
- [ ] 🙅 no documentation needed
## [optional] Are there any post-deployment tasks we need to perform?
<!-- Describe any additional tasks, if any, and provide steps. -->
## [optional] What gif best describes this PR or how it makes you feel?
<!-- Share a fun gif related to your PR! -->
### PR Title and Description Guidelines:
- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).
## Closing Issues
<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.
- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.
You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`
More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
ybensacq
added a commit
that referenced
this pull request
Aug 22, 2024
## Description 1. add elastic search manager to insert data in elastic search <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ybensacq
added a commit
that referenced
this pull request
Aug 23, 2024
## Description 1. make elasticsearch optionnal <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Aug 28, 2024
## Description
Add `get_fees_amount` to retrieve fees for a given token:
```cairo
struct FeesAmount {
fulfill_broker: u256,
listing_broker: u256,
ark: u256,
creator: u256,
}
fn get_fees_amount(
self: @t,
fulfill_broker: ContractAddress,
listing_broker: ContractAddress,
nft_address: ContractAddress,
nft_token_id: u256,
payment_amount: u256
) -> FeesAmount;
```
<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?
For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->
## What type of PR is this? (check all applicable)
- [ ] 🍕 Feature (`feat:`)
- [ ] 🐛 Bug Fix (`fix:`)
- [ ] 📝 Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] 🧑💻 Code Refactor (`refactor:`)
- [ ] 🔥 Performance Improvements (`perf:`)
- [ ] ✅ Test (`test:`)
- [ ] 🤖 Build (`build:`)
- [ ] 🔁 CI (`ci:`)
- [ ] 📦 Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`)
## Related Tickets & Documents
<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
## Added tests?
- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
## Added to documentation?
- [ ] 📜 README.md
- [ ] 📓 Documentation
- [ ] 🙅 no documentation needed
## [optional] Are there any post-deployment tasks we need to perform?
<!-- Describe any additional tasks, if any, and provide steps. -->
## [optional] What gif best describes this PR or how it makes you feel?
<!-- Share a fun gif related to your PR! -->
### PR Title and Description Guidelines:
- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).
## Closing Issues
<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.
- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.
You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`
More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
ptisserand
added a commit
that referenced
this pull request
Aug 28, 2024
## Description
Add support for maintenance mode, when `executor` is disabled, the
following functions will revert:
- `create_order`
- `cancel_order`
- `execute_order`
- `fulfill_order`
Here is the interface for maintenance mode:
```cairo
#[starknet::interface]
trait IMaintenance<T> {
fn is_enabled(self: @t) -> bool;
fn enable(ref self: T, enable: bool);
}
```
`IMaintenance::enable` can only be invoked by `admin`
<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?
For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->
## What type of PR is this? (check all applicable)
- [x] 🍕 Feature (`feat:`)
- [ ] 🐛 Bug Fix (`fix:`)
- [ ] 📝 Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] 🧑💻 Code Refactor (`refactor:`)
- [ ] 🔥 Performance Improvements (`perf:`)
- [x] ✅ Test (`test:`)
- [ ] 🤖 Build (`build:`)
- [ ] 🔁 CI (`ci:`)
- [ ] 📦 Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`)
## Related Tickets & Documents
<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
## Added tests?
- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
## Added to documentation?
- [ ] 📜 README.md
- [ ] 📓 Documentation
- [ ] 🙅 no documentation needed
## [optional] Are there any post-deployment tasks we need to perform?
<!-- Describe any additional tasks, if any, and provide steps. -->
## [optional] What gif best describes this PR or how it makes you feel?
<!-- Share a fun gif related to your PR! -->
### PR Title and Description Guidelines:
- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).
## Closing Issues
<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.
- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.
You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`
More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
ptisserand
added a commit
that referenced
this pull request
Sep 10, 2024
…ook on (#439) ## Description 1. Orderbook is now a component 2. Remove messaging in Starknet part 3. Add `version` and `order_type` in Orderbook component events 4. Move dependencies version to workspace Scarb.toml 5. Update to cairo 2.7.1, snforge 0.28 & OZ 0.15.1 <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
added a commit
that referenced
this pull request
Sep 10, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
gershon
added a commit
that referenced
this pull request
Sep 10, 2024
## Description <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Sep 11, 2024
…450) ## Description Add check in `cancel_order` to ensure: - caller is the canceller - canceller is the offerer <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [x] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ybensacq
added a commit
that referenced
this pull request
Sep 12, 2024
## Description 1. reset listing fields on transfer event <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Sep 14, 2024
## Description
Simplify core function and react hooks parameters.
Before:
```ts
const orderHash = await createOffer(config, {
starknetAccount: buyer,
offer: {
brokerId: accounts.listingBroker.address,
tokenAddress: STARKNET_NFT_ADDRESS,
tokenId,
startAmount: BigInt(10)
},
approveInfo: {
currencyAddress: config.starknetCurrencyContract,
amount: BigInt(10)
}
});
```
After:
```ts
const { orderHash } = await createOffer(config, {
account: buyer,
brokerAddress: accounts.listingBroker.address,
currencyAddress: config.starknetCurrencyContract,
tokenAddress,
tokenId,
amount: BigInt(10)
});
```
## What type of PR is this? (check all applicable)
- [ ] 🍕 Feature (`feat:`)
- [ ] 🐛 Bug Fix (`fix:`)
- [ ] 📝 Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] 🧑💻 Code Refactor (`refactor:`)
- [ ] 🔥 Performance Improvements (`perf:`)
- [ ] ✅ Test (`test:`)
- [ ] 🤖 Build (`build:`)
- [ ] 🔁 CI (`ci:`)
- [ ] 📦 Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`)
## Related Tickets & Documents
<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
## Added tests?
- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
## Added to documentation?
- [ ] 📜 README.md
- [ ] 📓 Documentation
- [ ] 🙅 no documentation needed
## [optional] Are there any post-deployment tasks we need to perform?
<!-- Describe any additional tasks, if any, and provide steps. -->
## [optional] What gif best describes this PR or how it makes you feel?
<!-- Share a fun gif related to your PR! -->
### PR Title and Description Guidelines:
- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).
## Closing Issues
<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.
- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.
You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`
More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
gershon
added a commit
that referenced
this pull request
Sep 17, 2024
## Description Update hook docs with v2 sdk version. ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [x] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ybensacq
added a commit
that referenced
this pull request
Sep 20, 2024
## Description 1. store price of sale <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ybensacq
added a commit
that referenced
this pull request
Oct 2, 2024
## Description 1. change currency_chain_id format <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
kwiss
pushed a commit
that referenced
this pull request
Oct 10, 2024
## Description This PR extends the existing NFT orderbook smart contract to add support for the ERC-1155 token standard - [x] ERC-1155 token contract successfully deployed on devnet - [x] Orderbook smart contract updated to support ERC-1155 tokens - [x] All existing ERC-721 functionality remains intact - [x] New ERC-1155 specific functions are implemented and tested - [x] Quantity handling is correctly implemented for ERC-1155 tokens - [x] All tests pass, including new tests for ERC-1155 functionality - [x] PR must be made with the branch https://github.com/ArkProjectNFTs/ark-project/tree/feat/contract-v2 as a base <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [x] 🧑💻 Code Refactor (`refactor:`) - [x] ✅ Test (`test:`) - [x] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes ## Added to documentation? - [x] 📜 README.md ## Closing Issues Closes #190 <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Oct 15, 2024
## Description - Create `orderbook` package to handle smart contract event parsing. - Remove unused crates from Cargo.toml <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [x] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Oct 23, 2024
#486) ## Description - Add missing emit of `OrderCancelled` event when an order is cancelled by a new one. - Fix local deployment - SDK: add missing `quantity` field in `FulfillInfo` <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [x] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [x] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Nov 26, 2024
## Description Add public enums for `OrderType` and `RouteType` <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
maissani
added a commit
that referenced
this pull request
Nov 27, 2024
## Description 1 - bump sqlx librairy to 0.8.2 <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [ ] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Dec 5, 2024
## Description 1. Add `reset_order_status` in orderbook 2. Fix call to`rollback_status` in`on_starknet_tx_failed` <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [x] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Dec 6, 2024
## Description Add block number sorting to ensure that events handling respect temporal order. <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
ptisserand
added a commit
that referenced
this pull request
Dec 9, 2024
…r failure (#509) ## Description 1. Process all events of a block even in case of handler failure 2. <!-- Please do not leave this blank. Describe the changes in this PR. What does it [add/remove/fix/replace]? For crafting a good description, consider using ChatGPT to help articulate your changes. --> ## What type of PR is this? (check all applicable) - [ ] 🍕 Feature (`feat:`) - [x] 🐛 Bug Fix (`fix:`) - [ ] 📝 Documentation Update (`docs:`) - [ ] 🎨 Style (`style:`) - [ ] 🧑💻 Code Refactor (`refactor:`) - [ ] 🔥 Performance Improvements (`perf:`) - [ ] ✅ Test (`test:`) - [ ] 🤖 Build (`build:`) - [ ] 🔁 CI (`ci:`) - [ ] 📦 Chore (`chore:`) - [ ] ⏩ Revert (`revert:`) - [ ] 🚀 Breaking Changes (`BREAKING CHANGE:`) ## Related Tickets & Documents <!-- Please use this format to link related issues: Fixes #<issue_number> More info: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Added tests? - [ ] 👍 yes - [ ] 🙅 no, because they aren't needed - [ ] 🙋 no, because I need help ## Added to documentation? - [ ] 📜 README.md - [ ] 📓 Documentation - [ ] 🙅 no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- Describe any additional tasks, if any, and provide steps. --> ## [optional] What gif best describes this PR or how it makes you feel? <!-- Share a fun gif related to your PR! --> ### PR Title and Description Guidelines: - Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs. - Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in your PR title. - Your PR title will be used as a commit message when merging. Make sure it adheres to [Conventional Commits standards](https://www.conventionalcommits.org/). ## Closing Issues <!-- Use keywords to close related issues. This ensures that the associated issues will automatically close when the PR is merged. - `Fixes #123` will close issue 123 when the PR is merged. - `Closes #123` will also close issue 123 when the PR is merged. - `Resolves #123` will also close issue 123 when the PR is merged. You can also use multiple keywords in one comment: - `Fixes #123, Resolves #456` More info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.