Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(order): add base auction order function & refactor testing setup #180

Merged
merged 9 commits into from
Nov 17, 2023

Conversation

kwiss
Copy link
Contributor

@kwiss kwiss commented Nov 15, 2023

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature (feat:)
  • πŸ› Bug Fix (fix:)
  • πŸ“ Documentation Update (docs:)
  • 🎨 Style (style:)
  • πŸ§‘β€πŸ’» Code Refactor (refactor:)
  • πŸ”₯ Performance Improvements (perf:)
  • βœ… Test (test:)
  • πŸ€– Build (build:)
  • πŸ” CI (ci:)
  • πŸ“¦ Chore (chore:)
  • ⏩ Revert (revert:)
  • πŸš€ Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Documentation
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

remiroyc
remiroyc previously approved these changes Nov 17, 2023
@kwiss kwiss enabled auto-merge November 17, 2023 15:16
@kwiss kwiss added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit ceb33aa Nov 17, 2023
6 checks passed
@kwiss kwiss deleted the feat/auction-order branch November 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants