Adjust bounds of freq-burst model and change default behavior #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mimics what was done in #92 but now for
freqburst_mono.py. This module already had monotonic kernels, however I noticed that the bounds were set to far too high, in light of recent results about how impactful burstiness is on massive galaxies especially. I'll show a comparison of plots of the old and new default models below, which shows that the new default model has much milder burst frequency than the previous model.Probably more importantly than the change to the default behavior, I think the new bounds on the burst frequency variable should result in much less extreme models of burstiness.
@gbeltzmo