Bring in monotonic Fburstpop model #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in
fburstpop_mono.py. This is a monotonic version offburstpop.py, analogous tofreqburst_mono.pyandavpop_mono.py. The default parameters are shown here:I fiddled around a bit with plotting a wide range of models within the unbounded space, and qualitatively this new model
fburstpop_mono.pyappears to be much more constrained than thefburstpop.pymodel we have been using. The default setting offburstpop.pyis fine, but it's got far more wide-ranging phenomenology than the new model. See below for plots.Here are a couple of typical example for randomly selected points in the u-param space of fburstpop_mono.py`:
Whereas here are a couple of examples from the
fburstpop.pymodel we have been using: