Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resizing schedule settings #899

Merged
merged 58 commits into from
Mar 21, 2024
Merged

Allow resizing schedule settings #899

merged 58 commits into from
Mar 21, 2024

Conversation

LouisPhilippeHeon
Copy link
Contributor

Closes #896

📖 Description

Upon scrolling in the list of settings, it will expand.

🧪 How Has This Been Tested?

Tested on android and iOS, both with light and dark mode.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

Capture d’écran, le 2023-11-23 à 16 21 51

@LouisPhilippeHeon LouisPhilippeHeon self-assigned this Nov 24, 2023
@LouisPhilippeHeon LouisPhilippeHeon requested a review from a team as a code owner November 24, 2023 00:37
MysticFragilist
MysticFragilist requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@MysticFragilist MysticFragilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit test à ajouter sinon tout est vraiment bien! 😄 Good job!

lib/ui/widgets/schedule_settings.dart Show resolved Hide resolved
@github-actions github-actions bot added size: XL and removed size: M labels Feb 6, 2024
LouisPhilippeHeon and others added 4 commits February 6, 2024 02:16
@LouisPhilippeHeon @github-actions
[BOT] Applying version.
fb67612
@clubapplets-server @github-actions
[BOT] Applying format.
e2f8bf8
@LouisPhilippeHeon
Merge branch 'master' into Allow-resizing-schedule-settings
6a99b9c 
# Conflicts:
#	lib/core/managers/course_repository.dart
#	lib/core/managers/user_repository.dart
#	lib/core/services/navigation_service.dart
#	lib/core/viewmodels/more_viewmodel.dart
#	lib/core/viewmodels/schedule_viewmodel.dart
#	lib/ui/views/dashboard_view.dart
#	lib/ui/views/grade_details_view.dart
#	lib/ui/views/schedule_view.dart
#	lib/ui/widgets/schedule_settings.dart
#	test/ui/views/grades_details_view_test.dart
#	test/ui/views/schedule_view_test.dart
#	test/ui/widgets/goldenFiles/scheduleSettingsView_1.png
#	test/viewmodels/dashboard_viewmodel_test.dart
#	test/viewmodels/schedule_viewmodel_test.dart
@LouisPhilippeHeon @github-actions
[BOT] Applying version.
6b98154
@github-actions github-actions bot added size: M and removed size: XL labels Mar 14, 2024
@github-actions GitHub Actions
Copy link

Coverage after merging Allow-resizing-schedule-settings into master will be

78.15%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.35%100%100%4.35%28, 30–42, 45–49, 52–54
lib/core/constants
   preferences_flags.dart0%100%100%0%61, 66, 68, 70–72, 75, 77–80, 82, 84
   widget_helper.dart100%100%100%100%
   quick_links.dart100%100%100%100%
   emergency_procedures.dart100%100%100%100%
   markers.dart100%100%100%100%
lib/core/managers
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–49, 51, 59, 61–63, 65, 72, 74–77
   course_repository.dart97.30%100%100%97.30%249, 257, 259–260, 444–445
   quick_link_repository.dart85.71%100%100%85.71%39–40
   settings_manager.dart89.15%100%100%89.15%221, 227, 230, 234, 236, 256, 258–259, 272, 274–276, 39, 88
   user_repository.dart91.38%100%100%91.38%137–139, 188, 309–311, 95–97
lib/core/models
   quick_link.dart100%100%100%100%
   quick_link_data.dart100%100%100%100%
   widget_models.dart100%100%100%100%
   feedback_issue.dart100%100%100%100%
   discovery.dart100%100%100%100%
   group_discovery.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
   faq_actions.dart100%100%100%100%
   faq_questions.dart100%100%100%100%
lib/core/services
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   app_widget_service.dart80%100%100%80%71, 73–78
   github_api.dart0%100%100%0%100, 103, 108, 110–114, 116–117, 120, 128–131, 135–136, 138, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 76, 81–87, 91, 93, 95–97, 99
   in_app_review_service.dart0%100%100%0%16, 20, 23, 27
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
   launch_url_service.dart0%100%100%0%22–24, 27–29, 32–33, 35–36, 42, 60–61, 64
   navigation_service.dart0%100%100%0%27, 30–31, 33–34, 41–42, 45–46, 49–51, 53, 58, 61, 63–64, 67–69, 71–72
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
   preferences_service.dart69.09%100%100%69.09%119–120, 122, 36, 38, 40, 43–45, 69–70, 80–82, 85, 87–88
   remote_config_service.dart0%100%100%0%101–103, 106–108, 111–112, 114–117, 119, 124–126, 46–48, 51–53, 56–58, 61–63, 66–68, 71–73, 76–78, 81–83, 86–88, 91–93, 96–98
   rive_animation_service.dart0%100%100%0%12–13, 16, 19–20, 28, 32–33, 35
   siren_flutter_service.dart0%100%100%0%13–14, 18–19, 23–25, 29–31, 35, 41
lib/core/utils
   cache_exception.dart33.33%100%100%33.33%10, 12
   animation_exception.dart20%100%100%20%15, 17–19
   utils.dart70.83%100%100%70.83%12–15, 17–18, 50
   login_mask.dart5%100%100%5%12, 15–16, 18–20, 23–30, 33–34, 37–39
lib/core/viewmodels
   grades_viewmodel.dart100%100%100%100%
   grades_details_viewmodel.dart96.55%100%100%96.55%53
   choose_language_viewmodel.dart100%100%100%100%
   quick_links_viewmodel.dart100%100%100%100%
   faq_viewmodel.dart41.67%100%100%41.67%30, 32–33, 35, 38, 41, 43
   web_link_card_viewmodel.dart62.50%100%100%62.50%35, 40–41
   not_found_viewmodel.dart100%100%100%100%
   profile_viewmodel.dart96%100%100%96%126–127
   dashboard_viewmodel.dart81.11%100%100%81.11%146–148, 150, 153, 240–241, 255–260, 262, 271–272, 314, 354–355, 357, 377, 381, 418, 420, 425, 463, 479–481, 483, 488–489, 543, 548, 550, 552, 554, 556, 559–560, 562, 565, 567, 569–570, 572–573, 576–577, 589–590
   startup_viewmodel.dart92.50%100%100%92.50%103, 138–139
   settings_viewmodel.dart100%100%100%100%
   schedule_viewmodel.dart80.77%100%100%80.77%100–105, 107, 122, 157–163, 202, 214, 269–270, 306, 356–360, 368–369, 392–395, 398–399, 431–432
   login_viewmodel.dart100%100%100%100%
   feedback_viewmodel.dart97.14%100%100%97.14%63
   schedule_settings_viewmodel.dart77.38%100%100%77.38%120–124, 140, 142, 144, 147, 150–151, 153, 67, 69–74
   more_viewmodel.dart66%100%100%66%111–113, 115–116, 118, 123–124, 143–144, 146–147, 149–150, 153–154, 66
   emergency_viewmodel.dart7.69%100%100%7.69%18, 20, 22–23, 25–27, 31, 33–34, 41–42
   security_viewmodel.dart50%100%100%50%37–38, 42–44, 46, 51–52
lib/ui/utils
   app_theme.dart0%100%100%0%6, 72–74, 77–82, 86–88, 94–99
   discovery_components.dart93.23%100%100%93.23%103, 134, 165, 195, 225, 41, 459, 466–467, 469, 471–476, 72
   loading.dart100%100%100%100%
lib/ui/views
   login_view.dart77.14%100%100%77.14%120–122, 152–153, 155, 168, 170, 172–174, 177, 183, 193, 209–210, 212, 257–258, 260–261, 58–60
   grade_details_view.dart95.78%100%100%95.78%142, 310, 66, 68–69, 74, 99
   security_view.dart75.41%100%100%75.41%108, 110–114, 45–47, 66–71
   emergency_view.dart54.55%100%100%54.55%34–40, 51–53
   faq_view.dart90.09%100%100%90.09%107–108, 203–207, 278–279, 282, 284
   about_view.dart71.64%100%100%71.64%129–130, 136–137, 143–144, 150–151, 157–158, 164–165, 170, 173, 175, 23–25, 92
   settings_view.dart100%100%100%100%
   more_view.dart83.72%100%100%83.72%110–112, 161–162, 164, 204–205, 207,

MysticFragilist
MysticFragilist approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@MysticFragilist MysticFragilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LouisPhilippeHeon LouisPhilippeHeon merged commit 79ecf5c into master Mar 21, 2024
7 checks passed
@LouisPhilippeHeon LouisPhilippeHeon deleted the Allow-resizing-schedule-settings branch March 21, 2024 01:51
@LouisPhilippeHeon LouisPhilippeHeon mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MysticFragilist MysticFragilist MysticFragilist approved these changes

@XavierPaquet-Rapold XavierPaquet-Rapold XavierPaquet-Rapold approved these changes

Assignees

@LouisPhilippeHeon LouisPhilippeHeon

Labels
size: M version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permettre à l'utilisateur d'augmenter la taille du widget des préférences du calendrier
4 participants
@LouisPhilippeHeon @MysticFragilist @XavierPaquet-Rapold @clubapplets-server