Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Red corners showing up in schedule settings bottom sheet and make the bottom sheet bigger #276

Closed
camillebrulotte opened this issue Oct 23, 2021 · 6 comments
Closed

Red corners showing up in schedule settings bottom sheet and make the bottom sheet bigger #276

camillebrulotte opened this issue Oct 23, 2021 · 6 comments
Labels
bug Something isn't working feature: Schedule Issue concerning the schedule section of the application platform: android platform: ios priority: low This issue is a low priority ready to develop This issue is ready to be taken.

Comments

@camillebrulotte
Copy link
Contributor

camillebrulotte commented Oct 23, 2021 •
edited
Loading

Describe the bug
When scrolling down the bottom sheet, you can see red corners at the top due to items that are "selected". Also, make the bottom sheet bigger when there is activity selection displayed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Schedule
  2. Click on the gear icon (to open the schedule settings)
  3. Scroll down
  4. See error

Expected behavior
We should not see the red corners when scrolling down.

Screenshots
@camillebrulotte camillebrulotte added bug Something isn't working platform: ios platform: android feature: Schedule Issue concerning the schedule section of the application priority: medium This issue is a medium priority labels Oct 23, 2021
@apomalyn apomalyn added priority: low This issue is a low priority and removed priority: medium This issue is a medium priority labels Oct 24, 2021
@apomalyn apomalyn mentioned this issue Nov 13, 2021
Merged
@camillebrulotte camillebrulotte changed the title Red corners showing up in schedule settings bottom sheet Red corners showing up in schedule settings bottom sheet and make the bottom sheet bigger Nov 16, 2021
@apomalyn apomalyn added the ready to develop This issue is ready to be taken. label Dec 14, 2021
@eneiss
Copy link
Contributor

eneiss commented Feb 4, 2022

@camillebrulotte what device did you use to get this bug? I just tried to reproduce it on my Samsung A41 but I don't have any red corners on the bottom sheet.
Did it get fixed in a previous release ? (I'm on 4.7.0)

@apomalyn
Copy link
Member

apomalyn commented Feb 4, 2022

@eneiss continue to scroll a bit 😄 the problem appears when a selected tile is completely behind the title (behind 'Parametres de l'horaire')

@eneiss
Copy link
Contributor

eneiss commented Feb 4, 2022

@eneiss continue to scroll a bit 😄 the problem appears when a selected tile is completely behind the title (behind 'Parametres de l'horaire')

I can't scroll any further though, so I guess the bug won't appear on a 20:9 screen then 🤷

@XavierPaquet-Rapold
Copy link
Contributor

Doesn't seem to be a problem anymore as of v4.21.5

@MysticFragilist
Copy link
Contributor

J'suis capable de reproduire sur mon device:

image

@LouisPhilippeHeon
Copy link
Contributor

Done in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature: Schedule Issue concerning the schedule section of the application platform: android platform: ios priority: low This issue is a low priority ready to develop This issue is ready to be taken.
Projects
Kanban
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@apomalyn @MysticFragilist @eneiss @camillebrulotte @XavierPaquet-Rapold @LouisPhilippeHeon