Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to use slide gesture to close keyboard #676

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: unable to use slide gesture to close keyboard #676

merged 1 commit into from
Jan 15, 2024

Conversation

LucasXu0
Copy link
Collaborator

keyboard.mp4

@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (71521ca) 76.41% compared to head (3c49678) 76.41%.

Files Patch % Lines
...b/src/editor/toolbar/mobile/mobile_toolbar_v2.dart 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files         295      295           
  Lines       13089    13089           
=======================================
  Hits        10002    10002           
  Misses       3087     3087

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 31a18c5 into AppFlowy-IO:main Jan 15, 2024
10 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 17, 2024
@q200892907
Merge branch 'main' into feat-zhiya
1c02c3b 
* main:
  fix: unable to use slide gesture to close keyboard (AppFlowy-IO#676)
  feat: optimize Enter operation (AppFlowy-IO#673)
  feat: parse nested numbered list (AppFlowy-IO#674)
  fix: headingBlockComponentBuilder doesn't use placeholderTextStyle (AppFlowy-IO#677)
  fix: the magnifier doesn't disappear when the selection is collapsed (AppFlowy-IO#675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LucasXu0