Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the magnifier doesn't disappear when the selection is collapsed #675

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

LucasXu0
Copy link
Collaborator

before

before.mp4

after

after.mp4

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (dccd4e8) 76.49% compared to head (95ea7c7) 76.41%.

Files Patch % Lines
...nt/service/selection/mobile_selection_service.dart 5.88% 16 Missing ⚠️
lib/src/render/selection/mobile_basic_handle.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   76.49%   76.41%   -0.09%     
==========================================
  Files         295      295              
  Lines       13074    13089      +15     
==========================================
+ Hits        10001    10002       +1     
- Misses       3073     3087      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 71521ca into AppFlowy-IO:main Jan 15, 2024
8 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 17, 2024
* main:
  fix: unable to use slide gesture to close keyboard (AppFlowy-IO#676)
  feat: optimize Enter operation (AppFlowy-IO#673)
  feat: parse nested numbered list (AppFlowy-IO#674)
  fix: headingBlockComponentBuilder doesn't use placeholderTextStyle (AppFlowy-IO#677)
  fix: the magnifier doesn't disappear when the selection is collapsed (AppFlowy-IO#675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant