fix: move cursor up/down issus #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasXu0
force-pushed
the
cursor_up_down
branch
from
04f5e6a
to
94c3d7e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 76.56% 76.48% -0.08%
==========================================
Files 295 295
Lines 13022 13041 +19
==========================================
+ Hits 9970 9975 +5
- Misses 3052 3066 +14 ☔ View full report in Codecov by Sentry. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Jan 10, 2024
* main: fix: move cursor up/down issue (AppFlowy-IO#657) fix: chinese IME feat: add markdown divider encoder parser (AppFlowy-IO#639) feat: support updating cursor position via spacebar (AppFlowy-IO#655) feat: support customizing cursor width (AppFlowy-IO#654)
Jei-sKappa
added a commit
to Jei-sKappa/appflowy-editor
that referenced
this pull request
Mar 21, 2024
Previously the `moveVertical` function only moved the cursor 'node to node' without thaking into consideration multiline nodes or some portion of a line with different fontSize (ex: a paragraph with size 16 but with a bolded word with size 32). This was caused by the PR AppFlowy-IO#657 that closes AppFlowy-IO#656 and AppFlowy-IO#589.
Jei-sKappa
added a commit
to Jei-sKappa/appflowy-editor
that referenced
this pull request
Mar 28, 2024
Previously the `moveVertical` function only moved the cursor 'node to node' without thaking into consideration multiline nodes or some portion of a line with different fontSize (ex: a paragraph with size 16 but with a bolded word with size 32). This was caused by the PR AppFlowy-IO#657 that closes AppFlowy-IO#656 and AppFlowy-IO#589.
Jei-sKappa
added a commit
to Jei-sKappa/appflowy-editor
that referenced
this pull request
Apr 13, 2024
Previously the `moveVertical` function only moved the cursor 'node to node' without thaking into consideration multiline nodes or some portion of a line with different fontSize (ex: a paragraph with size 16 but with a bolded word with size 32). This was caused by the PR AppFlowy-IO#657 that closes AppFlowy-IO#656 and AppFlowy-IO#589.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #656
closes #589
cursor.mp4