Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support updating cursor position via spacebar #655

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jan 8, 2024

closes #651

RPReplay_Final1704696521.MP4

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (49575bc) 76.78% compared to head (ed9c9a3) 76.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ice/ime/delta_input_on_floating_cursor_update.dart 0.00% 21 Missing ⚠️
lib/src/render/selection/mobile_basic_handle.dart 0.00% 13 Missing ⚠️
...component/service/ime/non_delta_input_service.dart 25.00% 3 Missing ⚠️
...tor_component/service/keyboard_service_widget.dart 0.00% 2 Missing ⚠️
...nt/service/selection/mobile_selection_service.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   76.78%   76.54%   -0.25%     
==========================================
  Files         293      294       +1     
  Lines       12969    13011      +42     
==========================================
+ Hits         9958     9959       +1     
- Misses       3011     3052      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit ca5b589 into AppFlowy-IO:main Jan 8, 2024
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 10, 2024
* main:
  fix: move cursor up/down issue (AppFlowy-IO#657)
  fix: chinese IME
  feat: add markdown divider encoder parser (AppFlowy-IO#639)
  feat: support updating cursor position via spacebar (AppFlowy-IO#655)
  feat: support customizing cursor width (AppFlowy-IO#654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] iOS support cursor positioning with longpress spacebar
1 participant