Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Main] Update Artifact Download Links #283

Closed
wants to merge 6 commits into from
Closed

[Main] Update Artifact Download Links #283

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
068d138
Merge branch 'ehp/v4.1_README' into ehp/main_v4.1_README
ericpassmore May 6, 2024
34e3cc7
updated artifact download links to v-next
ericpassmore May 6, 2024
381053d
merged in additional commits from release/4.1 branch
ericpassmore May 6, 2024
40e39ff
resolved conflict in CDT version
ericpassmore Aug 22, 2024
0accee8
update version to vnext-dev
ericpassmore Aug 22, 2024
bbbf629
updated download link to v4.1.0 no rc
ericpassmore Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ CDT currently supports Linux x86_64 Debian packages. Visit the [release page](ht
Download the appropriate version of the Debian package and then install it. To download and install the latest version, run the following:

```sh
wget https://github.com/AntelopeIO/cdt/releases/download/v4.0.1/cdt_4.0.1_amd64.deb
sudo apt install ./cdt_4.0.1_amd64.deb
wget https://github.com/AntelopeIO/cdt/releases/download/v4.1.1/cdt_4.1.1_amd64.deb
sudo apt install ./cdt_4.1.1_amd64.deb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it's best to leave main's download links to be the same as in the latest release. main's README is what users will see and follow. This is instructing users to download something that doesn't exist.

Copy link
Contributor Author

@ericpassmore ericpassmore May 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that makes sense. Moving PR to DRAFT. I'll hold off on this until, the new release is out.

```
### Debian package uninstall

Expand All @@ -28,9 +28,9 @@ sudo apt remove cdt

## Building from source

Recent Ubuntu LTS releases are the only Linux distributions that we fully support. Other Linux distros and other POSIX operating systems (such as macOS) are tended to on a best-effort basis and may not be full featured.
Recent Ubuntu LTS releases are the only Linux distributions that we fully support. Other Linux distros and other POSIX operating systems (such as macOS) are tended to on a best-effort basis and may not be full featured.

The instructions below assume that you are building on Ubuntu 20.04.
The instructions below assume that you are building on Ubuntu 20.04.

### Install dependencies

Expand Down Expand Up @@ -136,7 +136,7 @@ Installing CDT globally on your system will install the following tools in a loc
* cdt-strip
* eosio-pp
* eosio-wasm2wast
* eosio-wast2wasm
* eosio-wast2wasm

It will also install CMake files for CDT accessible within a `cmake/cdt` directory located within your system's `lib` directory.
#### Manual installation
Expand Down
Loading