[Main] Update Artifact Download Links #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
May 6, 2024
spoonincode
reviewed
May 6, 2024
README.md
Outdated
| wget https://github.com/AntelopeIO/cdt/releases/download/v4.0.1/cdt_4.0.1_amd64.deb | ||
| sudo apt install ./cdt_4.0.1_amd64.deb | ||
| wget https://github.com/AntelopeIO/cdt/releases/download/v4.1.1/cdt_4.1.1_amd64.deb | ||
| sudo apt install ./cdt_4.1.1_amd64.deb |
There was a problem hiding this comment.
imo it's best to leave main's download links to be the same as in the latest release. main's README is what users will see and follow. This is instructing users to download something that doesn't exist.
There was a problem hiding this comment.
I see that makes sense. Moving PR to DRAFT. I'll hold off on this until, the new release is out.
|
closing superseded by version bump and official 4.1.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme has version specific download links updating those links in release/4.1 branch. Includes commit to updates the same in
release/4.1branch