Merge pull request dotnet#550 from pgavlin/GetValueFromRuntimeHandle

Stub out getValueFromRuntimeHandle.
AndyAyersMS · May 7, 2015 · 8188ea7 · 8188ea7
2 parents e793ba7 + be3a522
commit 8188ea7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/include/Reader/readerir.h b/include/Reader/readerir.h
@@ -384,9 +384,8 @@ class GenIR : public ReaderBase {
 
   IRNode *getTypeFromHandle(IRNode *HandleNode) override;
 
-  IRNode *getValueFromRuntimeHandle(IRNode *Arg1) override {
-    throw NotYetImplementedException("getValueFromRuntimeHandle");
-  };
+  IRNode *getValueFromRuntimeHandle(IRNode *Arg1) override;
+
   IRNode *arrayGetDimLength(IRNode *Arg1, IRNode *Arg2,
                             CORINFO_CALL_INFO *CallInfo) override {
     throw NotYetImplementedException("arrayGetDimLength");

diff --git a/lib/Reader/readerir.cpp b/lib/Reader/readerir.cpp
@@ -3882,6 +3882,18 @@ IRNode *GenIR::getTypeFromHandle(IRNode *Arg1) {
   return (IRNode *)LLVMBuilder->CreateLoad(FieldAddress, IsVolatile);
 }
 
+IRNode *GenIR::getValueFromRuntimeHandle(IRNode *Arg1) {
+  // TODO: other JITs either
+  // a) do not optimize this path, or
+  // b) only optimize here if the incoming argument is the result of lowering
+  //    a ldtoken instruction.
+  //
+  // We don't yet have the ability do detect (b) yet; stick with (a) in the
+  // meantime.
+
+  return nullptr;
+}
+
 CORINFO_CLASS_HANDLE GenIR::inferThisClass(IRNode *ThisArgument) {
   Type *Ty = ((Value *)ThisArgument)->getType();
   assert(Ty->isPointerTy());