This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Stub out getValueFromRuntimeHandle. #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
| @@ -3718,7 +3718,8 @@ IRNode *GenIR::callHelper(CorInfoHelpFunc HelperID, bool MayThrow, IRNode *Dst, | |||
| (Dst == nullptr) ? Type::getVoidTy(LLVMContext) : Dst->getType(); | |||
| return (IRNode *)callHelperImpl(HelperID, MayThrow, ReturnType, Arg1, Arg2, | |||
| Arg3, Arg4, Alignment, IsVolatile, NoCtor, | |||
| CanMoveUp).getInstruction(); | |||
| CanMoveUp) | |||
| .getInstruction(); | |||
There was a problem hiding this comment.
What's with these weird dangling .?
There was a problem hiding this comment.
When clang-format says jump, I jump.
There was a problem hiding this comment.
Shrug. I figured. But it looks strange to me.
There was a problem hiding this comment.
I agree. We'll see how the formatting job feels about it, since it's likely that I'm running a slightly newer version of clang-format locally.
Other JITs either a) do not optimize this path, or b) only optimize here if the incoming argument is the result of lowering a ldtoken instruction. We don't yet have the ability do detect (b); stick with (a) in the meantime.
pgavlin
force-pushed
the
GetValueFromRuntimeHandle
branch
from
3fa2a1f to
be3a522
Compare
pgavlin
added a commit
that referenced
this pull request
May 7, 2015
Stub out getValueFromRuntimeHandle.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other JITs either
a) do not optimize this path, or
b) only optimize here if the incoming argument is the result of lowering
a ldtoken instruction.
We don't yet have the ability do detect (b); stick with (a) in the meantime.