Do not strip knockout comments from .html files
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would have been introduced as part of AmpersandHQ/ampersand-magento2-upgrade-patch-helper@v1.18.1...v1.19.0 ChatGPT may have assisted with the regex
|
@hostep can you give this a tweak and see if it fixes it for you? |
|
@convenient: excellent, works perfectly fine like this! (maybe the comment on top of that regex will need to be tweaked to mention it doesn't apply to ko lines) |
|
@tr33m4n would you be so kind as to merge and tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have been introduced as part of v1.18.1...v1.19.0
ChatGPT may have assisted with the regex in
src/Ampersand/PatchHelper/Patchfile/Sanitiser.phpFor #117
Checklist