Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in knockout templates using html comments are incorrectly marked as ignored #117

Closed
hostep opened this issue Feb 8, 2024 · 0 comments · Fixed by #118
Closed

Comments

@hostep
Copy link
Contributor

hostep commented Feb 8, 2024

Hi!

I'm working on an upgrade from Magento 2.2.7 to 2.4.6 (believe it or not)
And the tool sees the following changes as something to ignore:

diff -ur -N vendor_orig/magento/module-sales-rule/view/frontend/web/template/payment/discount.html vendor/magento/module-sales-rule/view/frontend/web/template/payment/discount.html
--- vendor_orig/magento/module-sales-rule/view/frontend/web/template/payment/discount.html	2024-02-08 12:25:15.000000000 +0100
+++ vendor/magento/module-sales-rule/view/frontend/web/template/payment/discount.html	2023-07-21 09:34:46.000000000 +0200
@@ -44,6 +44,9 @@
                         </button>
                     <!-- /ko -->
                 </div>
+                <!-- ko foreach: getRegion('captcha') -->
+                <!-- ko template: getTemplate() --><!-- /ko -->
+                <!-- /ko -->
             </div>
         </form>
     </div>

Which in my opinion it shouldn't ignore. This is probably because of the html comments.
Would it be easy for those ko html comments to be detected as not something to ignore?

Thanks!

@tr33m4n tr33m4n linked a pull request Feb 9, 2024 that will close this issue
3 tasks
@tr33m4n tr33m4n closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants