Allow user defined key bindings (refactor replxx_impl.cxx).

[ajg]

It'd be nice to have the option to auto-complete a line/command with the first available hint when pressing enter/return, rather than have to do it explicitly by tabbing. This would allow emulating the code completion behavior of typical IDEs (and search engine input boxes.)

It doesn't look like this is currently possible, or is it?

Thanks.

[AmokHuginnsson]

Hello.
I think that could be a nice feature if optional. There is one thing I would like to do before such feature would be implemented. Currently all "function" keys are handled in one big switch, This code looks awful. I was thinking about splitting this switch into separate functions, one per case and do dispatching through (runtime) registered handlers rather then through switch, the implementation is C++11 after all. That way we would have cleaner code and ability to support custom (user defined) keybindings.

What do you think?

[ajg]

That sounds reasonable to me—let me know if I can help.

[AmokHuginnsson]

I have been busy with other things, but I had time to think about the best approach. It seems to me that dynamic key binding implementation would add more global static state and we would add new mess in one place while we would clean up the other. @georgi-d has opened another issue (#2) for this and it looks like to do it right we would have to start with global state removal. I see that this project gets cloned so my resistance to adding code smells gets stronger. I do not know if there is any feasible way to split the work but I am open to suggestion. Anyway I will look into #2 for now.

[yury]

@ajg hmm, it is interesting, I can't tab to cycle completion list. It is just shown above. But actually I need tabbing through behavior. I think something changed recently.

[AmokHuginnsson]

@yury To access next/prev hist one has to use CTRL+<up arrow>/CTRL+<down arrow>.
When desired hint is selected one use <TAB> key to complete given selection.

[yury]

Yep, found that shortcut in code. But on iOS kb it is very unconvineient shortcut ;(

Zsh style tabbing would awesome.

[AmokHuginnsson]

@ajg

I finally started key binding rewrite. But now I am afraid that custom key bindings are not actually related to your original problem. At least I am not entirely sure what API to expose to the client application so the user can request/implement the behavior you are after.

I think new issue should be opened for "Enter to accept current hint" enhancement because I already referenced this issue (#6) as top priority refactoring in many places.

I am sorry that I hijacked your enhancement request.

[AmokHuginnsson]

@yury

I think it would be best if you open new issue for "Cycling through hints with Tab key.".
That way your request won't be lost, as this issue is about something entirely else now :(

[AmokHuginnsson]

@ajg

Can you explain more what do you mean in the original issue?
I understand that you want to use Enter key to accept current hint.
What about automatic hint selection?
You referenced IDEs, some of the IDEs have first hint "selected" by default, e.g.:

In IDE (C++ code):

std::string s;
s.

here, after user enters . the first hint is append() method,
pressing Enter inserts append(...) into the editor.

Would you like to have the same behavior in replxx,
I mean, to have first available hint selected by default and used when user presses Enter key?

[AmokHuginnsson]

@yury

You can now achieve tab cycle completion through binding
Replxx::ACTION::COMPLETE_NEXT to <tab> key via Replxx::bind_key() and Replxx::invoke()

[yury]

Thanks, man.

I did heavy changes. Can check right away. But, I hope, will check that.
Thanks