feat: remove summary from componentlist and rename summary2 #14557
Conversation
github-actions
bot
added
area/ui-editor
|
Warning Rate limit exceeded@lassopicasso has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modifies the handling of summary components within the application. Specifically, it updates the Norwegian language file to change references from "Summary2" to "Summary" in deletion prompts. Additionally, the component configuration has been adjusted to remove "Summary" from the schema and conditionally include "Summary2" based on a feature flag. The test suite is also updated to exclude "Summary" from the available components list. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lassopicasso
changed the title
lassopicasso
changed the title
lassopicasso
added
the
skip-manual-testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
frontend/packages/ux-editor/src/data/formItemConfig.ts (1)
461-469: Remove unused Summary component definition.The Summary component definition is no longer used as it's been removed from schemaComponents and isn't referenced elsewhere in the codebase.
🧹 Nitpick comments (1)
frontend/packages/ux-editor/src/data/formItemConfig.test.ts (1)
25-25: Update test comment to include Summary component.The comment should be updated to reflect that Summary is now also excluded:
- /** Test that all components, except Custom, Payment, Subform and Summary2 (since behind featureFlag), are available in one of the visible lists */ + /** Test that all components, except Custom, Payment, Subform, Summary, and Summary2 (since behind featureFlag), are available in one of the visible lists */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
frontend/language/src/nb.json(3 hunks)frontend/packages/ux-editor/src/data/formItemConfig.test.ts(1 hunks)frontend/packages/ux-editor/src/data/formItemConfig.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- frontend/language/src/nb.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build environment and run e2e test
- GitHub Check: CodeQL
- GitHub Check: Testing
🔇 Additional comments (1)
frontend/packages/ux-editor/src/data/formItemConfig.ts (1)
592-592: Verify feature flag usage across the codebase.The Summary2 component is conditionally included based on the FeatureFlag.Summary2 feature flag. Let's verify its usage across the codebase.
✅ Verification successful
Review Verification: Consistent Feature Flag Usage in Summary2
The shell script output confirms that the only production usage of the Summary2 feature flag is in the configuration file (frontend/packages/ux-editor/src/data/formItemConfig.ts), where the Summary2 component is conditionally added using the feature flag. Other appearances ofComponentType.Summary2are in tests, mocks, or rendering paths where explicit flag guards aren’t required. This is expected behavior since the controlled inclusion is handled centrally in the configuration.
- Summary2 inclusion in
formItemConfig.tsis properly guarded usingshouldDisplayFeature(FeatureFlag.Summary2).- All other references (tests, component renders, mocks) are acceptable and rely on the configuration for conditional inclusion.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of Summary2 feature flag # Expected: All Summary2 component usage should be guarded by the feature flag # Search for Summary2 component usage echo "Searching for Summary2 component usage..." rg "ComponentType\.Summary2" -A 3 # Search for Summary2 feature flag usage echo "Searching for Summary2 feature flag usage..." rg "FeatureFlag\.Summary2" -A 3Length of output: 9299
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14557 +/- ##
==========================================
- Coverage 95.73% 95.73% -0.01%
==========================================
Files 1908 1908
Lines 24876 24877 +1
Branches 2846 2847 +1
==========================================
Hits 23816 23816
Misses 799 799
- Partials 261 262 +1 ☔ View full report in Codecov by Sentry. |
lassopicasso
removed
the
skip-manual-testing
|
NB! Move to blocked after reviewed, this PR shouldn't be merged before the feature flag is removed |
Description
🚨 Do not merge to main before summary2 is released.
Removed
summary-component from component list in current design and new design.Added
summary2in new design for component list.Renamed
summary2to display as summary, and usesummary's help text insummary2Don't merge to main before
summary2is released.Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
Summary by CodeRabbit
Summarycomponent from visibility in relevant lists, ensuring accurate component availability.