-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update JSON schema for Summary2 #14529
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the JSON schema for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/packages/ux-editor/src/testing/schemas/json/component/Summary2.schema.v1.json
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build environment and run e2e test
- GitHub Check: CodeQL
- GitHub Check: Testing
🔇 Additional comments (1)
frontend/packages/ux-editor/src/testing/schemas/json/component/Summary2.schema.v1.json (1)
Line range hint
1-106
: Overall changes look good!The schema updates successfully enhance the Summary2 component's configurability by:
- Adding default grid behavior
- Introducing compact mode option
- Expanding override capabilities
The changes maintain schema integrity and align well with the PR objectives.
frontend/packages/ux-editor/src/testing/schemas/json/component/Summary2.schema.v1.json
Show resolved
Hide resolved
frontend/packages/ux-editor/src/testing/schemas/json/component/Summary2.schema.v1.json
Show resolved
Hide resolved
frontend/packages/ux-editor/src/testing/schemas/json/component/Summary2.schema.v1.json
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14529 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 1902 1902
Lines 24778 24778
Branches 2840 2840
=======================================
Hits 23715 23715
Misses 802 802
Partials 261 261 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/language/src/nb.json (2)
Line range hint
14-15
: Consider adding more context to code list labels.While the translations are correct, consider adding more descriptive text to help users understand the purpose of code lists, especially for the "clear_search_button_label" which could benefit from additional context.
Consider updating the translations to be more descriptive:
- "app_content_library.code_lists.clear_search_button_label": "Fjern søkeord", + "app_content_library.code_lists.clear_search_button_label": "Fjern søkeord fra kodeliste",
1392-1392
: Add more context to isCompact translation.Since this is part of the Summary2 schema update, consider making the translation more specific to its context.
Consider updating the translation to be more descriptive:
- "ux_editor.component_properties.isCompact": "Bruk kompakt visning", + "ux_editor.component_properties.isCompact": "Bruk kompakt visning i oppsummering",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/language/src/nb.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Build environment and run e2e test
- GitHub Check: Typechecking and linting
- GitHub Check: Testing
- GitHub Check: CodeQL
🔇 Additional comments (2)
frontend/language/src/nb.json (2)
Line range hint
1-13
: LGTM! API error messages are well-structured.The new API error messages follow a consistent format and provide clear feedback in Norwegian.
Line range hint
16-17
: LGTM! Validation messages are clear and consistent.The validation error messages provide clear guidance and maintain consistency with existing message patterns.
Description
Update JSON schema for Summary2
Verification
Summary by CodeRabbit
Summary by CodeRabbit
New Features
isCompact
property to control component compactness.Localization Improvements