Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useTableSorting tests fails randomly, causing PR check to fail #13631

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: useTableSorting tests fails randomly, causing PR check to fail #13631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06f7aa8
Fix flaky unit test
Jondyr Sep 25, 2024
df831e2
Merge branch 'main' into fix/flaky-unit-test-usetablesorting
framitdavid Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions frontend/libs/studio-components/src/hooks/useTableSorting.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useTableSorting } from './useTableSorting';
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook } from '@testing-library/react';
import type { Rows } from '../components';

describe('useTableSorting', () => {
Expand Down Expand Up @@ -28,7 +28,7 @@ describe('useTableSorting', () => {

it('should sort rows in ascending order when a column is clicked', async () => {
const { result } = renderHook(() => useTableSorting(rows, { enable: true }));
await waitFor(() => result.current.handleSorting('creator'));
act(() => result.current.handleSorting('creator'));

const creatorsAscending: string[] = [];
result.current.sortedRows.forEach((row) => {
Expand All @@ -42,8 +42,8 @@ describe('useTableSorting', () => {

it('should sort rows in descending order when the same column is clicked again', async () => {
const { result } = renderHook(() => useTableSorting(rows, { enable: true }));
await waitFor(() => result.current.handleSorting('creator'));
await waitFor(() => result.current.handleSorting('creator'));
act(() => result.current.handleSorting('creator'));
act(() => result.current.handleSorting('creator'));

const creatorsDescending: string[] = [];
result.current.sortedRows.forEach((row) => {
Expand All @@ -57,8 +57,8 @@ describe('useTableSorting', () => {

it('should reset the sort direction to ascending when a different column is clicked', async () => {
const { result } = renderHook(() => useTableSorting(rows, { enable: true }));
await waitFor(() => result.current.handleSorting('creator'));
await waitFor(() => result.current.handleSorting('id'));
act(() => result.current.handleSorting('creator'));
act(() => result.current.handleSorting('id'));
expect(result.current.sortedRows).toEqual(rows);
});

Expand Down