-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: useTableSorting tests fails randomly, causing PR check to fail #13631
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13631 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 1502 1502
Lines 20581 20581
Branches 2492 2492
=======================================
Hits 19603 19603
Misses 869 869
Partials 109 109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
I added skip-release notes on this one since it's only "internal" code that is changed. 😊 Waiting for all PR checks to turn green before merging. Since it's a unit test that is fixed, no further manual testing is required. 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! :)
Description
useTableSorting
tests failed randomly (around once per 10 test runs for me locally). This is likely because useTableSorting's useEffect was not properly waited for. ChangedwaitFor
toact
.Example of PR check failing:
https://github.com/Altinn/altinn-studio/actions/runs/11014485052/job/30585221160?pr=13573
tested locally with:
(for i in {1..100}; do (yarn test --ci useTableSorting.test.tsx)&; done);
Related Issue(s)
Verification
Documentation