Update scroll styling for file lists #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/filelist-scrollable-styling
BrianWhitneyAI
approved these changes
Feb 27, 2025
SeanLeRoy
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds gradient overlays per the recommended styling for making it clearer when file lists are scrollable
closes #335
Changes
Added overlays to the FileLists and to the root DirectoryTree
Needed to do some funky css to account for the disappearing scrollbars in Chrome/Firefox vs permanently visible scrollbars in Safari/Chromium
NOT addressed
The styling guide includes recommendations for when to show or hide scrollbars. Unfortunately, we generally don't have control over this since it's determined by the browser settings
Testing
Visual checks on different browsers and web vs desktop
Screenshots
Apologies for weirdly annotated screenshots
Chrome/Firefox: (scrollbars disappear)
Safari/Desktop: (scrollbars always visible)