feature/robust-cache-messages #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aswallace
approved these changes
Feb 27, 2025
| const file = fileDetails.find((f) => f.id === fileId); | ||
| const isAlreadyCached = file?.annotations.some( | ||
| ({ name, values }) => | ||
| name === "Should Be in Local Cache" && values[0] === true |
There was a problem hiding this comment.
we might want to use the AnnotationName.SHOULD_BE_IN_LOCAL constant here and elsewhere (saw that the full string is also used in other places) if possible
kmitcham
approved these changes
Feb 28, 2025
SeanLeRoy
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to resolve #417 and clear up some misleading reporting about the cache action. This PR separates the net success message into two separate messages for the two condition (while keeping messages separate). it also handles plural/singular cases.