Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/empty csv for manually selected files #437

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

BrianWhitneyAI
Copy link
Contributor

Description

The purpose of this pr is to resolve #415. We have a situation with imported data where the query we build to download a csv does not account for single selected files ie. (CTRL + Select) this is because we pass it a list of index ranges. which might look like:

                    indexRanges: [
                        { start: 0, end: 0 },
                        { start: 2, end: 2 },
                    ],

When we build a query it does not register these ranges since they're not inclusive. However if we pass it indexRanges: [{ start: 0, end: 2 }] it works correctly.

Changes

  • Add conditional to handle single index files
  • Seperate the download method which has gotten quite heavy
  • Add tests for this case (Comparing the query)

@BrianWhitneyAI BrianWhitneyAI marked this pull request as ready for review February 14, 2025 23:19
@BrianWhitneyAI BrianWhitneyAI merged commit a0b3933 into main Feb 20, 2025
7 checks passed
@BrianWhitneyAI BrianWhitneyAI deleted the bugfix/empty-csv-for-manually-selected-files branch February 20, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: saving CSV of files
3 participants