Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration testing: unset irrelevant env variables #2902

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

li-boxuan
Copy link
Collaborator

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

See here

If one has OPENAI_API_KEY and OPENAI_BASE_URL defined in their environment, the prompts of CodeActAgent would change, and cause integration tests to fail.

Give a brief summary of what the PR does, explaining any non-trivial design decisions

Unset some environmental variables that are not used in integration tests, but could disturb the results.

Other references

Test evidence: trust me bro

@li-boxuan li-boxuan marked this pull request as ready for review July 12, 2024 06:23
Copy link
Collaborator

@tobitege tobitege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@xingyaoww xingyaoww merged commit ebbc0e6 into All-Hands-AI:main Jul 12, 2024
2 checks passed
@li-boxuan li-boxuan deleted the test/unset-env-var branch July 15, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants