arch: deprecating recall action and search_memory
#2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingyaoww
commented
Jul 11, 2024
li-boxuan
reviewed
Jul 12, 2024
| @@ -161,6 +161,25 @@ parse_pptx(file_path: str) -> None: | |||
| Args: | |||
| file_path: str: The path to the file to open. | |||
|
|
|||
| parse_audio(file_path: str, model: str = 'whisper-1') -> None: | |||
There was a problem hiding this comment.
Your local environmental variables seem to mess this up.
There was a problem hiding this comment.
Can you remove OPENAI_API_KEY and OPENAI_BASE_URL? I'll add an unset to the regenerate.sh later
There was a problem hiding this comment.
merged! now re-generating integration tests now!
tobitege
requested changes
Jul 12, 2024
|
@tobitege done! more than happy to! |
xingyaoww
changed the title
search_memory
Great! The codebase smells so much nicer now with all that baggage gone! 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Remove
RecallActionto clean up the codebase and makeRuntimemore concise, since the current implementation isRecallis not really working.I think @enyst's memory representation + condensation idea (#2709, #2021) is probably better to implement both
recallandsummary, other than putting them intoRuntimeclass?Give a brief summary of what the PR does, explaining any non-trivial design decisions
Other references