[ADF-5575] Should use declaration-no-important rule in the stylelint-… #9302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekpluta
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
jacekpluta
changed the title
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
from
92c6566 to
802d54a
Compare
jacekpluta
commented
Feb 5, 2024
lib/core/src/lib/layout/components/sidenav-layout/sidenav-layout.component.scss
Show resolved
Hide resolved
jacekpluta
commented
Feb 5, 2024
jacekpluta
commented
Feb 5, 2024
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
from
802d54a to
398d60f
Compare
jacekpluta
changed the title
lib/content-services/src/lib/version-manager/version-upload.component.scss
Outdated
Show resolved
Hide resolved
lib/core/src/lib/layout/components/layout-container/layout-container.component.scss
Outdated
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/group/components/group-cloud.component.scss
Outdated
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/people/components/people-cloud.component.scss
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/process-list/components/start-process.component.scss
Outdated
Show resolved
Hide resolved
|
@jacekpluta please fix sonarcloud problems: |
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
from
398d60f to
9b429a5
Compare
|
@jacekpluta please correct PR title - there is incorrect jira number: |
jacekpluta
changed the title
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
from
9b429a5 to
690656f
Compare
jacekpluta
commented
Feb 15, 2024
lib/process-services/src/lib/attachment/process-attachment-list.component.scss
Show resolved
Hide resolved
jacekpluta
commented
Feb 15, 2024
lib/process-services/src/lib/task-list/components/start-task.component.scss
Show resolved
Hide resolved
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
3 times, most recently
from
c06b09f to
6ce9bcd
Compare
lib/core/src/lib/comments/comment-list/comment-list.component.scss
Outdated
Show resolved
Hide resolved
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
2 times, most recently
from
3176906 to
8399f25
Compare
DenysVuika
reviewed
Feb 15, 2024
| @@ -1,20 +1,20 @@ | |||
| .adf-filter { | |||
| &-button { | |||
| margin-left: -7px !important; | |||
| &-button#{&}-button { | |||
There was a problem hiding this comment.
this notation here makes no sense https://sass-lang.com/playground/#eJwzNNRLTEnTTcvMKUktUqjmUgACNd2k0pKS/DzlarVaKBMqAwK5iUXpmXm6OalpJVYKuuYFFdZgqVquWgBnQxX3
There was a problem hiding this comment.
I've removed all of the classes duplication like '&-button#{&}-button' and '.adf-datatable-header.adf-datatable-header'. I've replacted them with :has, :is or increased nesting.
|
the style classname duplication looks like even worse hack than !important |
lib/core/src/lib/comments/comment-list/comment-list.component.scss
Outdated
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Feb 16, 2024
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
3 times, most recently
from
eb9142b to
916a6eb
Compare
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
2 times, most recently
from
1a6fa9c to
5ef3875
Compare
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
7 times, most recently
from
44bb270 to
9fd71f5
Compare
…config.json file to avoid use of !important in ADF
jacekpluta
force-pushed
the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
from
9fd71f5 to
75acf55
Compare
…ant-rule-in-the-stylelint-config
|
jacekpluta
deleted the
ADF-5575-should-use-declaration-no-important-rule-in-the-stylelint-config
branch
AleksanderSklorz
pushed a commit
that referenced
this pull request
Mar 27, 2024
…config.json file to avoid use of !important in ADF (#9302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…config.json file to avoid use of !imporatnt in ADF
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
!imporant properies have been removed.
Each of the components was checked in case of any issues and either !Important was unnecessary or specificity had to be increased.
What is the new behaviour?
Behaviour shouldn't change.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: