[ACS-6565] Should use declaration-no-important rule in the stylelint-…

…config.json file to avoid use of !imporatnt in ADF
Alfresco · Feb 5, 2024 · 802d54a · 802d54a
1 parent 81c17da
commit 802d54a
Show file tree

Hide file tree

Showing 32 changed files with 214 additions and 214 deletions.
diff --git a/demo-shell/src/app/components/cloud/cloud-filters-demo.component.scss b/demo-shell/src/app/components/cloud/cloud-filters-demo.component.scss
@@ -1,4 +1,4 @@
 app-cloud-task-filters .app-filters__entry,
 app-cloud-process-filters .app-filters__entry {
-    padding-left: 0 !important;
+    padding-left: 0;
 }
diff --git a/demo-shell/src/app/components/files/files.component.scss b/demo-shell/src/app/components/files/files.component.scss
@@ -1,5 +1,5 @@
-.app-container {
-    margin: 10px !important;
+.app-container.app-container {
+    margin: 10px;
 }
 
 .app-error-message {

diff --git a/lib/content-services/src/lib/content-user-info/content-user-info.component.scss b/lib/content-services/src/lib/content-user-info/content-user-info.component.scss
@@ -148,7 +148,7 @@
     }
 
     &-hide-tab .mat-tab-label-active {
-        display: none !important;
+        display: none;
     }
 }
 

diff --git a/lib/content-services/src/lib/document-list/components/document-list.component.scss b/lib/content-services/src/lib/document-list/components/document-list.component.scss
@@ -109,7 +109,7 @@
 
 .adf-empty-list-header {
     height: 32px;
-    opacity: 0.26 !important;
+    opacity: 0.26;
     font-size: var(--theme-headline-font-size);
     line-height: 1.33;
     letter-spacing: -1px;
@@ -179,8 +179,8 @@
 }
 
 .adf-datatable-gallery-thumbnails {
-    .adf-datatable-card .adf-datatable-row {
-        height: 300px !important;
+    .adf-datatable-card .adf-datatable-row:is(adf-datatable-row) {
+        height: 300px;
 
         img {
             height: 130px;

diff --git a/.../src/lib/search/components/search-filter-container/search-filter-container.component.scss b/.../src/lib/search/components/search-filter-container/search-filter-container.component.scss
@@ -1,6 +1,6 @@
 .adf-filter {
-    &-button {
-        margin-left: -7px !important;
+    &-button.mat-icon-button {
+        margin-left: -7px;
 
         .adf-icon {
             opacity: 1;
@@ -10,24 +10,24 @@
                 color: var(--theme-primary-color);
             }
 
-            .mat-badge-active {
-                border: 2px solid var(--adf-theme-background-card-color) !important;
+            .mat-badge-active.mat-badge-content {
+                border: 2px solid var(--adf-theme-background-card-color);
             }
         }
 
-        .mat-badge-content {
+        .mat-badge-after .mat-badge-content {
             width: 10px;
             height: 10px;
-            top: -3px !important;
-            right: -6px !important;
+            top: -3px;
+            right: -6px;
         }
     }
 
     &-container {
         display: flex;
         flex-direction: column;
         padding: 15px 15px 10px;
-        color: var(--adf-theme-foreground-text-color-087) !important;
+        color: var(--adf-theme-foreground-text-color-087);
 
         .adf-facet-buttons {
             display: none;
@@ -38,7 +38,7 @@
         }
 
         input {
-            background: 2px solid var(--adf-theme-background-card-color) !important;
+            background: 2px solid var(--adf-theme-background-card-color);
         }
     }
 

diff --git a/...rvices/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.scss b/...rvices/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.scss
@@ -11,6 +11,7 @@ adf-search-filter-tabbed {
     // https://github.com/angular/components/issues/27426
     .mat-tab-body.mat-tab-body-active .mat-tab-body-content {
         display: block;
+        /* stylelint-disable no-descending-specificity declaration-no-important */
         visibility: visible !important;
     }
 

diff --git a/lib/content-services/src/lib/social/rating.component.scss b/lib/content-services/src/lib/social/rating.component.scss
@@ -24,7 +24,7 @@ $adf-average-star-color: #808080;
         width: 25px;
 
         .mat-list-item-content {
-            padding: 0 !important;
+            padding: 0;
         }
 
         &:hover {
@@ -38,7 +38,7 @@ $adf-average-star-color: #808080;
 
     .adf-grey-star,
     .adf-average-star {
-        color: $adf-average-star-color !important;
+        color: $adf-average-star-color;
     }
 }
 

diff --git a/lib/content-services/src/lib/tag/tag-node-list.component.scss b/lib/content-services/src/lib/tag/tag-node-list.component.scss
@@ -49,13 +49,13 @@
         margin: -1px 0 0 10px;
     }
 
-    .adf-tag-chips-delete-icon {
+    .adf-tag-chips-delete-icon.mat-chip-remove {
         font-size: var(--theme-title-font-size);
         background-repeat: no-repeat;
         display: inline-block;
         fill: currentcolor;
         height: 20px;
         width: 20px;
-        color: var(--theme-primary-color-default-contrast) !important;
+        color: var(--theme-primary-color-default-contrast);
     }
 }
diff --git a/lib/content-services/src/lib/tree/components/tree.component.scss b/lib/content-services/src/lib/tree/components/tree.component.scss
@@ -80,11 +80,11 @@ $tree-header-font-size: 12px !default;
         font-weight: bold;
         line-height: 24px;
         letter-spacing: 0;
-        min-height: $tree-row-height !important;
+        min-height: $tree-row-height;
         font-size: $tree-header-font-size;
         color: var(--adf-theme-foreground-text-color);
         box-sizing: border-box;
-        padding-top: 12px !important;
+        padding-top: 12px;
 
         &:focus {
             outline-offset: -1px;

diff --git a/...ew/components/card-view-selectitem/select-filter-input/select-filter-input.component.scss b/...ew/components/card-view-selectitem/select-filter-input/select-filter-input.component.scss
@@ -21,8 +21,8 @@ $select-filter-height: 4em !default;
     }
 }
 
-.mat-select-panel.adf-select-filter {
-    transform: none !important;
-    overflow-x: hidden !important;
+.mat-select-panel.adf-select-filter[role="listbox"] {
+    transform: none;
+    overflow-x: hidden;
     max-height: calc(256px + #{$select-filter-height});
 }
diff --git a/lib/core/src/lib/clipboard/clipboard.theme.scss b/lib/core/src/lib/clipboard/clipboard.theme.scss
@@ -1,7 +1,7 @@
 .adf-copy-tooltip {
     position: absolute;
     background: var(--theme-primary-color);
-    color: var(--theme-primary-color-default-contrast) !important;
+    color: var(--theme-primary-color-default-contrast);
     font-size: var(--theme-caption-font-size);
     padding: 2px 5px;
     border-radius: 5px;
@@ -13,7 +13,7 @@
 
 .adf-sticky-header {
     .adf-copy-tooltip {
-        top: 85% !important;
-        bottom: 0 !important;
+        top: 85%;
+        bottom: 0;
     }
 }
diff --git a/lib/core/src/lib/comments/comment-list/comment-list.component.scss b/lib/core/src/lib/comments/comment-list/comment-list.component.scss
@@ -1,68 +1,70 @@
-.adf {
-    &-comment-img-container {
-        width: 40px;
-        height: 100%;
-        display: flex;
-        align-self: flex-start;
-        padding-top: 18px;
-    }
+.adf-comment-list {
+    .adf {
+        &-comment-img-container {
+            width: 40px;
+            height: 100%;
+            display: flex;
+            align-self: flex-start;
+            padding-top: 18px;
+        }
 
-    &-comment-list-item {
-        white-space: initial;
-        display: table-row-group;
-        padding-top: 12px;
-        overflow: hidden;
-        height: 100% !important;
-        background-position: center;
-    }
+        &-comment-list-item.mat-list-item {
+            white-space: initial;
+            display: table-row-group;
+            padding-top: 12px;
+            overflow: hidden;
+            height: 100%;
+            background-position: center;
+        }
 
-    &-comment-user-icon {
-        padding: 10px 5px;
-        width: 30px;
-        background-color: var(--theme-primary-color);
-        color: var(--theme-primary-color-default-contrast);
-        border-radius: 50%;
-        font-size: var(--theme-subheading-2-font-size);
-        text-align: center;
-        height: 20px;
-        background-size: cover;
-    }
+        &-comment-user-icon {
+            padding: 10px 5px;
+            width: 30px;
+            background-color: var(--theme-primary-color);
+            color: var(--theme-primary-color-default-contrast);
+            border-radius: 50%;
+            font-size: var(--theme-subheading-2-font-size);
+            text-align: center;
+            height: 20px;
+            background-size: cover;
+        }
 
-    &-comment-user-name {
-        width: 100%;
-        padding: 2px 10px;
-        font-weight: 600;
-        font-size: var(--theme-body-1-font-size);
-    }
+        &-comment-user-name {
+            width: 100%;
+            padding: 2px 10px;
+            font-weight: 600;
+            font-size: var(--theme-body-1-font-size);
+        }
 
-    &-comment-message {
-        width: 100%;
-        padding: 2px 10px;
-        white-space: pre-line !important;
-        font-size: var(--theme-body-1-font-size);
-        letter-spacing: -0.2px;
-        line-height: 1.43;
-        color: var(--adf-theme-foreground-text-color);
-    }
+        &-comment-message.mat-line {
+            width: 100%;
+            padding: 2px 10px;
+            white-space: pre-line;
+            font-size: var(--theme-body-1-font-size);
+            letter-spacing: -0.2px;
+            line-height: 1.43;
+            color: var(--adf-theme-foreground-text-color);
+        }
 
-    &-comment-message-time {
-        margin-top: 5px;
-        width: 100%;
-        padding: 2px 10px;
-        font-size: var(--theme-caption-font-size);
-        color: var(--adf-theme-foreground-text-color);
-    }
+        &-comment-message-time {
+            margin-top: 5px;
+            width: 100%;
+            padding: 2px 10px;
+            font-size: var(--theme-caption-font-size);
+            color: var(--adf-theme-foreground-text-color);
+        }
 
-    &-comment-contents {
-        width: 100%;
-        padding-top: 12px;
-        padding-left: 5px;
-    }
+        &-comment-contents {
+            width: 100%;
+            padding-top: 12px;
+            padding-left: 5px;
+        }
 
-    &-people-img {
-        border-radius: 90%;
-        width: 40px;
-        height: 40px;
-        vertical-align: middle;
+        &-people-img {
+            border-radius: 90%;
+            width: 40px;
+            height: 40px;
+            vertical-align: middle;
+        }
     }
 }
diff --git a/lib/core/src/lib/datatable/components/columns-selector/columns-selector.component.scss b/lib/core/src/lib/datatable/components/columns-selector/columns-selector.component.scss
@@ -79,8 +79,8 @@ $adf-columns-selector-space: 12px;
         border: 1px solid var(--theme-background-color);
         background: var(--theme-background-color);
 
-        :focus {
-            outline: none !important;
+        &:focus {
+            outline: none;
         }
     }
 

diff --git a/lib/core/src/lib/datatable/components/datatable/datatable.component.html b/lib/core/src/lib/datatable/components/datatable/datatable.component.html
@@ -254,7 +254,7 @@
                                     [tooltip]="getCellTooltip(row, col)">
                                 </adf-icon-cell>
                             </div>
-                            <div *ngSwitchCase="'date'" class="adf-cell-value" [attr.tabindex]="data.getValue(row, col, resolverFn)? 0 : -1"
+                            <div *ngSwitchCase="'date'" class="adf-cell-value adf-cell-date" [attr.tabindex]="data.getValue(row, col, resolverFn)? 0 : -1"
                                  [attr.data-automation-id]="'date_' + (data.getValue(row, col, resolverFn) | adfLocalizedDate: 'medium') ">
                                 <adf-date-cell class="adf-datatable-center-date-column-ie"
                                     [data]="data"
@@ -403,7 +403,6 @@
         <div *ngIf="!loading && noPermission"
              role="row"
              [class.adf-datatable-row]="display === 'list'"
-             [class.adf-datatable-card-permissions]="display === 'gallery'"
              class="adf-no-permission__row">
             <div class="adf-no-permission__cell adf-no-content-container adf-datatable-cell">
                 <ng-template *ngIf="noPermissionTemplate"
-Original file line number
+Diff line change
@@ Expand Up / @@ -148,7 +148,7 @@ @@
         }
         &-hide-tab .mat-tab-label-active {
-            display: none !important;
+            display: none;
         }
     }
@@ Expand Down @@